MacPorts-1.8.0: build from tar ball or selfupdate fails to install on Tiger if default source is a local directory maintained with svn

[dbevans (David B. Evans)]

Situation:

Mac OS X 10.4.11 ppc
Xcode 2.5
Upgrading from 1.7.1 using tarball
Default prefix (/opt/local)

/opt/local/etc/macports/sources.conf contains:

file:///opt/macports/trunk/dports/ [default]

which refers to a svn working directory copy of the trunk port repository

Installation using defaults as follows:

cd MacPorts-1.8.0-rc1
./configure
make
sudo make install

make install fails as follows:

/usr/local/bin/tclsh src/upgrade_sources_conf_default.tcl /opt/local
couldn't execute "svn": no such file or directory
    while executing
"while {[gets $sourcesConfChannel line] >= 0} {
   set addDefault false
   if {!$defaultSeen && ![regexp {^\s*#|^$} $line]} {
      if {[regexp {^([\w-..."
    (file "src/upgrade_sources_conf_default.tcl" line 34)
make: *** [install] Error 1

Tiger doesn't come with svn installed in the system directories but /opt/local/bin/svn is installed from the previous version of Mac Ports but it's not in the installer's path.

I worked around this by commenting out the svn based source in sources.conf (install warned it couldn't find a default repository but didn't fail) and then re-enabling it after installation was complete.

[jmroot (Joshua Root)]

Pretty sure this would also be the case with 1.7.1, so at least it's not a regression...

[blb@…]

It did change a bit in r54364, though I'm also concerned about "/usr/local/bin/tclsh".

[dbevans (David B. Evans)]

I completely overlooked that it was using tcl from /usr/local/bin

So nuked /usr/local completely and tried again

First installed 1.7.1 from tar ball. Installed perfectly using /usr/bin/tclsh now. No problem with svn.

Then tried 1.8.0rc1. Same failure as before with substitution of /usr/bin/tclsh

Hope this helps

[dbevans (David B. Evans)]

Problem persists in 1.8.0 final release.

[dbevans (David B. Evans)]

After time to think about this some more, the problem is that the svn binary being installed by a previous version of MacPorts, is not in the installer's restricted path.

Configure allows the path to svn to be specified using the environment variable SVN but doesn't check to see if it exists.

I suggest that configure be modified to do such a check (perhaps including the target install prefix) to see if svn exists and error out if it does not with a message about using SVN to set where it might be even though it is not always necessary.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #21000.

[jmroot (Joshua Root)]

1.8.1 milestone is closing, moving open tickets out

[jmroot (Joshua Root)]

Attempted fix attached, please test.

[jmroot (Joshua Root)]

Seems fine in my testing. Committed in r61302.

[jmroot (Joshua Root)]

Merged to 1.8 branch in r61303.