Ticket #20900 (closed defect: fixed)
googlecode livecheck not working with http://project-name.googlecode.com style urls
| Reported by: | cedric.luthi@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | MacPorts 1.8.2 |
| Component: | base | Version: | 1.8.0 |
| Keywords: | Cc: | snc@…, ryandesign@… | |
| Port: |
Description
As I'm unable to reopen #20723, I'm creating this new ticket.
googlecode livecheck code assumes the homepage of a googlecode project is in the format http://code.google.com/p/project-name/
This is not always true (e.g. the mp4v2 port).
The attached patch also accepts the http://project-name.googlecode.com format.
Attachments
Change History
comment:1 follow-up: ↓ 3 Changed 4 years ago by snc@…
Is the differing homepage simply a matter they both work and we only check for one?
comment:3 in reply to: ↑ 1 Changed 4 years ago by cedric.luthi@…
Replying to snc@…:
Is the differing homepage simply a matter they both work and we only check for one?
Yes, exactly.
comment:4 Changed 4 years ago by snc@…
Check out the code that's in trunk. Does it do what you're after?
The livecheck.name section is moved up from the section you were patching, it seems.
comment:5 Changed 4 years ago by cedric.luthi@…
I just tried to build the trunk (r57011), but it still does not work:
$ port -v livecheck mp4v2 Error: cannot check if mp4v2 was updated (regex didn't match)
Where (what changeset) exactly did the livecheck.name section move up happened?