distcc 3.1 fails to build on 10.6

[luis.beca@…]

distcc 3.1 fails to build on Snow Leopard. See attached build log.

[kiwi.2008@…]

Cc Me!

[kiwi.2008@…]

[First time poster]

Partial patch attached. Removes several build errors, but I'm not sure about the following one: 'strndup' is not in /usr/include anywhere on Snow Leopard ...

/usr/bin/gcc-4.2 -I/opt/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/opt/local/etc\"" -DPKGDATADIR="\"/opt/local/share/distcc\"" -Isrc -I"./src" -I"./lzo"  -Werror -O2 -arch x86_64 -MD -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wmissing-declarations -Wuninitialized -D_THREAD_SAFE  -o src/daemon.o -c src/daemon.c
cc1: warnings being treated as errors
src/hosts.c:135: warning: declaration of 'strndup' shadows a built-in function
make: *** [src/hosts.o] Error 1
make: *** Waiting for unfinished jobs....

Removing the function declaration gives you something similar

/usr/bin/gcc-4.2 -I/opt/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/opt/local/etc\"" -DPKGDATADIR="\"/opt/local/share/distcc\"" -Isrc -I"./src" -I"./lzo"  -Werror -O2 -arch x86_64 -MD -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wmissing-declarations -Wuninitialized -D_THREAD_SAFE  -o src/hosts.o -c src/hosts.c
cc1: warnings being treated as errors
src/hosts.c: In function ‘dcc_parse_hosts’:
src/hosts.c:538: warning: implicit declaration of function ‘strndup’
src/hosts.c:538: warning: incompatible implicit declaration of built-in function ‘strndup’
make: *** [src/hosts.o] Error 1

[kiwi.2008@…]

Partial patch

[jmdeldin@…]

Cc Me!

[kiwi.2008@…]

Portfile patch for Snow Leopard

[kiwi.2008@…]

Avoid conflict with builtin strndup function

[kiwi.2008@…]

Avoid gcc 4.2.1 compiler warnings

[kiwi.2008@…]

The files

• Portfile-snowleopard.diff
• patch-avoid-builtin-strndup.diff
• patch-avoid-compile-warnings.diff

fix build problems on Snow Leopard

[kiwi.2008@…]

Provide symlink dir (ala ccache port)

[kyle.tarplee@…]

Is anyone going to commit these changes? It seems like you have fixes but they do no good until the portfile is updated, right?

[snc@…]

Cc Me!

[dports@…]

Cc Me!

[dports@…]

I can confirm that the patch provided in the following files works for me:

• Portfile-snowleopard.diff
• patch-avoid-builtin-strndup.diff
• patch-avoid-compile-warnings.diff

Can we get these committed?

[macsforever2000@…]

Replying to dports@…:

I can confirm that the patch provided in the following files works for me:

• Portfile-snowleopard.diff
• patch-avoid-builtin-strndup.diff
• patch-avoid-compile-warnings.diff

Can we get these committed?

I committed these 3 in r62129. Can someone with Leopard test this please?

Also, I am not clear what the patch Portfile-symlinkdir.diff is for? If it's for the ccache port, then another ticket should be opened for it so it can be assigned to the maintainer of that port.

[snc@…]

Replying to macsforever2000@…:

I committed these 3 in r62129. Can someone with Leopard test this please?

I get a build failure on Leopard with trunk. See attached.

[snc@…]

leopard build log

[snc@…]

Replying to snc@…:

I get a build failure on Leopard with trunk. See attached.

Of course, the changes might not be in my source tree yet …

[snc@…]

Replying to snc@…:

Of course, the changes might not be in my source tree yet …

The patches were in place and ran.

[macsforever2000@…]

Replying to snc@…:

The patches were in place and ran.

So did it compile on Leopard before the patches? If so, then I will apply them only in darwin 10.

[dports@…]

Replying to macsforever2000@…:

So did it compile on Leopard before the patches? If so, then I will apply them only in darwin 10.

I wouldn't think these patches could cause this error.

Is this a +universal problem?

[dports@…]

Replying to macsforever2000@…:

Also, I am not clear what the patch Portfile-symlinkdir.diff is for? If it's for the ccache port, then another ticket should be opened for it so it can be assigned to the maintainer of that port.

No, I think it's intended for this port. It creates a directory /opt/local/libexec/distcc with symlinks like 'gcc', 'g++' etc so that you can add it to your PATH and have 'gcc' automatically invoke distcc. ccache does something similar already.

[snc@…]

Replying to macsforever2000@…:

So did it compile on Leopard before the patches? If so, then I will apply them only in darwin 10.

No, build was unsuccessful for me when I axed the patchfiles from the Portfile.

Replying to dports@…:

Is this a +universal problem?

No defaults variants are set on this system—+universal was not used.

[snc@…]

failed leopard build without patches

[anshuman.aggarwal@…]

Is this ever going to be committed for snow leopard?

[dports@…]

So what's the status of this one?

I gather that it's broken under 10.5?

Is anyone having trouble with 10.6? It seems to work for me, though doesn't build universal.

[jmr@…]

No response; seems fine to me; closing.