New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #22022 (closed update: fixed)

Opened 5 years ago

Last modified 5 years ago

UPDATE: Solfege 3.14.1 -> 3.14.9

Reported by: allencmcbride@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: snc@…
Port: solfege

Description

Patch file to update solfege port to version 3.14.9. Several language enhancements, bug fixes, and a few new features.

Attachments

Portfile-solfege.diff (906 bytes) - added by allencmcbride@… 5 years ago.
patch to update solfege from 3.14.1 to 3.14.9
Portfile-solfege.2.diff (1.1 KB) - added by allencmcbride@… 5 years ago.
patch-src-configwindow.py.diff (805 bytes) - added by allencmcbride@… 5 years ago.
patch-src-mainwin.py.diff (568 bytes) - added by allencmcbride@… 5 years ago.

Change History

Changed 5 years ago by allencmcbride@…

patch to update solfege from 3.14.1 to 3.14.9

comment:1 Changed 5 years ago by jmr@…

  • Keywords haspatch maintainer added; solfege 3.14.9 removed
  • Version 1.8.1 deleted

Changed 5 years ago by allencmcbride@…

Changed 5 years ago by allencmcbride@…

Changed 5 years ago by allencmcbride@…

comment:2 in reply to: ↑ description Changed 5 years ago by allencmcbride@…

I added two new patch files, suggested by Solfege's author, to force manual pages to be displayed in an external web browser, because of a problem relating to gtktextview. And I added the corresponding updated Portfile patch.

comment:3 Changed 5 years ago by snc@…

  • Cc snc@… added

Currently, this port pulls in a mix of python25 and python26 in addition to not being able to find pygtk2

I tried moving it entirely to python26 and still received the pygtk2 error; I'd like to add --disable-pygtk-test.

Thoughts?

comment:4 Changed 5 years ago by snc@…

Note, it did install and launch with the disable flag added.

comment:5 Changed 5 years ago by allencmcbride@…

Thanks for trying it! I had tried moving everything to python26 a version or two back and it didn't work, but now I try it and it's working fine. So that sounds good. The disable flag sounds fine too, though on my computer it doesn't have trouble finding pygtk2. Do you know why it might work for one person and not another? Also, I was thinking of getting rid of the libgtkhtml dependency... apparently it doesn't do anything unless you use the --enable-gtkhtml flag. And when I do that I get "ImportError: No module named gtkhtml2" Would that be a good idea?

comment:6 follow-ups: ↓ 7 ↓ 9 Changed 5 years ago by snc@…

I'm not really sure why it cannot find pygtk2. I assume that py26-gtk is what provides it, so I'm at a loss in that matter. If we can figure out why we can always revise the portfile.

I'll go ahead commit with enable-gtkhtml removed.

comment:7 in reply to: ↑ 6 Changed 5 years ago by ram@…

Replying to snc@…:

I'm not really sure why it cannot find pygtk2. I assume that py26-gtk is what provides it, so I'm at a loss in that matter. If we can figure out why we can always revise the portfile.

I ran into a similar problem with py26-matplotlib, sometimes the build would fail to find pygtk2 and I had no idea why; the only solution that was found was to add PKG_CONFIG_PATH="${python.prefix}/lib/pkgconfig/" to build.env

comment:8 Changed 5 years ago by snc@…

Thanks Raim!

I'll add it and give it a swing, and then update it real quick if it works.

comment:9 in reply to: ↑ 6 Changed 5 years ago by allencmcbride@…

Replying to snc@…:

I'll go ahead commit with enable-gtkhtml removed.

You mean with the libgtkhtml dependency removed? Because enable-gtkhtml isn't there now, is it?

Thanks both of you for your help.

comment:10 Changed 5 years ago by snc@…

It was there and I've removed it …

comment:11 Changed 5 years ago by allencmcbride@…

Thanks. I think I'm in over my head a little, but once I see the changes you commit I'll probably understand.

comment:12 Changed 5 years ago by snc@…

  • Status changed from new to closed
  • Resolution set to fixed

Alright, base commit was in r60453. The pygtk fix was in r60457.

comment:13 Changed 5 years ago by snc@…

The enable-gtkhtml wasn't there, the dependency was. Sorry about the confusion.

comment:14 Changed 5 years ago by allencmcbride@…

No problem; thanks again. I tried the changes you committed and they work fine for me.

Note: See TracTickets for help on using tickets.