Opened 14 years ago

Closed 14 years ago

#22288 closed update (fixed)

Update Portfile: libfreespace 0.4

Reported by: burgess.jt@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: libfreespace

Description

Updating libfreespace to 0.4 release, and adding a step to install a kernel extension that allows libfreespace to access usb devices.

Attachments (2)

Portfile (1.6 KB) - added by burgess.jt@… 14 years ago.
libfreespace-0.4 Portfile
libfreespace.diff (1.5 KB) - added by ryandesign (Ryan Carsten Schmidt) 14 years ago.

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by burgess.jt@…

Attachment: Portfile added

libfreespace-0.4 Portfile

comment:1 Changed 14 years ago by jmroot (Joshua Root)

Keywords: haspatch maintainer added; libfreespace removed
Summary: Update Portfile: libfreespaceUpdate Portfile: libfreespace 0.4
Version: 1.8.1

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

In r60398 I committed a variation of your suggested change to the master_sites which should work even for release candidates and three-component version numbers.


    file delete -force /System/Library/Extensions/FreespaceDeviceDriver.kext
    file copy ${worksrcpath}/osx/FreespaceDeviceDriver.kext /System/Library/Extensions/FreespaceDeviceDriver.kext
    file attributes /System/Library/Extensions/FreespaceDeviceDriver.kext -owner root -group wheel -permissions rwxr-xr-x

Ports should not install things outside the destroot. This should be changed to:

    xinstall -d ${destroot}/System/Library/Extensions
    file copy ${worksrcpath}/osx/FreespaceDeviceDriver.kext ${destroot}/System/Library/Extensions
    file attributes ${destroot}/System/Library/Extensions/FreespaceDeviceDriver.kext -owner root -group wheel -permissions rwxr-xr-x

The port should also indicate that the fact that it violates the mtree is intentional:

destroot.violate_mtree yes

    touch /System/Library/Extensions.mkext

I assume with this line you're trying to force the kext cache to rebuild? This article says touching /System/Library/Extensions is the better future-proof way to do that -- though that page is from 2002. If you have more recent information that contradicts that, please let me know.


So that we can more easily see what was changed, it is be better to submit a patch rather than a full Portfile. I'm attaching a patch of my proposed changes. Do they look ok to commit?

Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: libfreespace.diff added

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r68757, however I now get the problem described in #25220.

Note: See TracTickets for help on using tickets.