odcctools 20061117_0 is incompatible with building tcl 8.5.8

[stephen@…]

When building Tcl, the build fails because of a duplicate definition of an enumeration. I worked around it by adding an #ifndef like this to /opt/local/include/mach-o/arch.h:

#ifndef _ARCHITECTURE_BYTE_ORDER_H_
enum NXByteOrder {
  NX_UnknownByteOrder,
  NX_LittleEndian,
  NX_BigEndian
};
#endif

This prevents that definition from conflicting with an identical definition in /usr/include/architecture/byte_order.h, and with that in place the build completes successfully.

Given the apparent age of what is presumably the current MacPorts release of odcctools, I guess it's (nearly) unused, obsolete, and deprecated. ISTR having removed it before, but G95 depends on it, and I guess it got pulled back in that way.

It might be preferable to do

#ifndef _ARCHITECTURE_BYTE_ORDER_H_
#error You probably ought to remove odcctools before building anything else!
#endif

as heaven only knows what other damage that ancient musty code might be doing....

[toby@…]

g95 does not depend on odcctools, and there are already a few tickets about odcctools being broken. Closing.

[jmr@…]

Well, it does on Tiger, but that's covered by another ticket as well I believe. There is a newer release of odcctools, but it really shouldn't be needed when building on OS X at all.