Opened 14 years ago

Closed 14 years ago

#23067 closed enhancement (fixed)

mlt 0.4.6: update to new upstream version 0.4.10 + variant no_x11

Reported by: dominik.kriegner@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc: ddennedy (Dan Dennedy)
Port: mlt

Description

Update to upstream 0.4.10 and a variant no_x11 should be added, because the build fails during compiling the gtk2 module (file consumer_gtk2.c). The header file gdk/gdkx.h is not available if gtk2 was built with the +no_x11 +quartz variants.

I do not know if it is possible remove the gtk2 dependency from mlt in this case?

Attachments (1)

mlt-0.4.10-Portfile.diff (602 bytes) - added by dominik.kriegner@… 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 in reply to:  description ; Changed 14 years ago by ddennedy (Dan Dennedy)

Replying to dominik.kriegner@…:

I do not know if it is possible remove the gtk2 dependency from mlt in this case?

Yes, MLT is not highly dependent upon the gtk2 module although it does provide a good, flexible, general purpose scaler. The fallbacks suffer in either quality or limited in resolution.

Anyways, as the maintainer, I agree with the changes in the patch, including the new variant.

comment:2 in reply to:  1 Changed 14 years ago by dominik.kriegner@…

Is it possible to remove the gtk2 depedence if mlt is used configured with --disable-gtk2? If this is the case I would suggest to add depends_lib-delete port:gtk2 to the new variant in the Portfile

comment:3 Changed 14 years ago by ddennedy (Dan Dennedy)

Ah, yes, I forgot about that explicit dependency in the Portfile. Yes, there are no other GTK dependencies when you --disable-gtk2. Please send an update with that option in the variant section. Thanks.

Changed 14 years ago by dominik.kriegner@…

Attachment: mlt-0.4.10-Portfile.diff added

comment:4 Changed 14 years ago by dominik.kriegner@…

I updated the Portfile patch to include the depends_lib-delete port:gtk2 line in the no_x11 variant.

Maybe this issue with the gtk2 module can be solved different in future releases. When I saw correctly only one call to a function from the missing gdkx.h file is done in the problematic consumer_gtk2.c, maybe there is some replacement for this function when gtk2+no_x11+quartz is installed?

comment:5 Changed 14 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

This was basically done in r64070 except it was updated to 0.5.0.

Note: See TracTickets for help on using tickets.