p5-svn-notify universal variant fails

[ryandesign (Ryan Carsten Schmidt)]

--->  Fetching p5-svn-notify
--->  Verifying checksum(s) for p5-svn-notify
--->  Extracting p5-svn-notify
--->  Configuring p5-svn-notify
Error: Target org.macports.configure returned: configure failure: shell command " cd "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_perl_p5-svn-notify/work/SVN-Notify-2.80" && /opt/local/bin/perl Makefile.PL --disable-dependency-tracking INSTALLDIRS=vendor " returned error 255
Command output: Malformed argument '--disable-dependency-tracking' at /opt/local/lib/perl5/vendor_perl/5.8.9/Module/Build/Compat.pm line 272.

Error: Unable to upgrade port: 1

[ryandesign (Ryan Carsten Schmidt)]

p5-svn-notify doesn't appear to install any architecture-specific files, so it should get the standard block that's been added to other noarch ports for MacPorts 1.9:

if {[info exists supported_archs]} {
    supported_archs noarch
} else {
    universal_variant no
}

[danielluke (Daniel J. Luke)]

--disable-dependency-tracking isn't going to be valid for anything that uses the perl5 portgroup. I would suggest that this also indicates a bug in the perl5 portgroup.

[ryandesign (Ryan Carsten Schmidt)]

Are you sure? Certainly several other p5 ports have no problem with that option and don't complain about it. Picking from among the perl ports I have installed on my machine that do install architecture-specific files, p5-cairo and p5-clone don't complain, for example. Certainly ports that don't install architecture-specific files don't need this option, nor should they have a universal variant at all, which is why they should use "supported_archs noarch" as of MacPorts 1.9 (or the above block until then). I made a sweep through the existing p5 ports to mark the noarch ones, but I either missed p5-svn-notify or may have deliberately excluded ports that had a maintainer (I don't remember).

[danielluke (Daniel J. Luke)]

The perl5 portgroup doesn't run configure (the 'configure phase' uses perl to build a makefile), so --disable-dependency-tracking is never appropriate (but it probably doesn't do any harm with most invocations - it's just being ignored).

I'll take a look at p5-svn-notify to get this fixed in this port in the short term, but it's still probably something that can/should be addressed in the perl5 portgroup (and yes, some perl modules build binaries that would need to be compiled universal, so it's not going to be appropriate to just specify no universal variant/noarch in the portgroup).

[ryandesign (Ryan Carsten Schmidt)]

Replying to dluke@…:

The perl5 portgroup doesn't run configure (the 'configure phase' uses perl to build a makefile), so --disable-dependency-tracking is never appropriate

Indeed! So you're right, that should just be removed in the portgroup.

[ryandesign (Ryan Carsten Schmidt)]

Fixed the portgroup in r68549.

[danielluke (Daniel J. Luke)]

Fixed the port in r68560