qt4-mac @4.7.1 +universal Portfile referring to obsolete universal_sysroot

[corwin.amber@…]

Since the use of universal_sysroot for compiling backward-compatible binaries has been dropped from the MacPorts trunk, the recommended method according to #19875 is to use macosx_deployment_target. The Qt-4 Portfile ignores this variable and sets ${SDK} and ${MACOSX_DEPLOYMENT_TARGET} through use of ${os.version}, which causes the linker to fail.

Attempted on 10.6.4 with macosx_deployment_target == 10.5.

[michaelld (Michael Dickens)]

Can you try the attached patch & see if it does what you want?

[michaelld (Michael Dickens)]

"svn diff" of 'qt4-mac' Portile, hopefully allowing the user to set TARGET and SDK

[jmroot (Joshua Root)]

You should leave out all that info exists stuff; universal_target and universal_sysroot are gone for good. The only thing you really need to care about is macosx_deployment_target. Note that there is a configure.sdkroot variable which will be nonempty in situations where an SDK is needed, which basically means when $macosx_deployment_target != $macosx_version, or when building universal on a ppc tiger machine.

[corwin.amber@…]

I can confirm that this patch works. These are the debug messages I got from the ui_msg's:

--->  Extracting qt4-mac
--->  Applying patches to qt4-mac
Using 'macosx_deployment_target' to get TARGET: '10.5'
TARGET is '10.5'
--->  Configuring qt4-mac
Using 'configure.sdkroot' for SDK: '/Developer/SDKs/MacOSX10.5.sdk'
--->  Building qt4-mac

[michaelld (Michael Dickens)]

2nd try: "svn diff" of 'qt4-mac' Portile, hopefully allowing the user to set TARGET and SDK

[michaelld (Michael Dickens)]

OK; per your recommendations I've reworked the patch & attached the new one that doesn't use the universal_FOO stuff but still makes sure the variables TARGET and SDK are set. Please give it a whirl / view & see if it meets all of the necessary criteria.

[jmroot (Joshua Root)]

Looks correct, but you really don't need the TARGET variable. You can assume that macosx_deployment_target exists and has a reasonable value. (It'll just be empty on non-Darwin platforms, not that you're required to care about those anyway.)

[michaelld (Michael Dickens)]

Fixed in r74980. I left the TARGET stuff for now; might change it later ...