Opened 13 years ago

Closed 12 years ago

#27361 closed defect (fixed)

httrack @3.43.9_0 md5sum missing and possible path problems

Reported by: abstractius@… Owned by: overhacked (Ross Williams)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt)
Port: httrack

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Hello, it felt like the Twilight Zone when I got

/opt/local/bin/webhttrack: line 162: md5sum: command not found

in my System Version: Mac OS X 10.6.5 (10H574).

It looks like this dependency has been there for ages and OSX only includes md5, of course one of the solutions is simply to symlink md5sum, but how could this have been missed for so long! Now, I haven't used httrack for a long while but even after fixing the script I get

** Warning: use the webhttrack frontend if available
usage: /opt/local/bin/htsserver [--port <port>] <path-to-html-root-dir> [key value [key value]..]
example: /opt/local/bin/htsserver /usr/share/httrack/
/opt/local/bin/webhttrack(99076): could not spawn htsserver

Looks like some other path or filename is mixed up as well? unbelievable considering the package has at least a couple of happy users!

Attachments (3)

httrack.diff (441 bytes) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.
portfile patch
patch-src-webhttrack.diff (1.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.
patch-src-htsweb.c.diff (523 bytes) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to ross@…
Port: httrack added
Priority: HighNormal

Please remember to fill in the Port field and cc the maintainer. As per the ticket guidelines, the High priority is reserved for the use of MacPorts team members.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)

Is this still a problem in 3.44.1, to which the port was just updated?

comment:3 Changed 13 years ago by overhacked (Ross Williams)

Gosh, I remember submitting an upstream patch for this, and I thought it had been incorporated into httrack many versions ago. I'll research and talk with the author, then update the status here.

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

I tested 3.44.4 (#33062) and the issue remains. I'm attaching a patch to fix this the correct way. May I commit it, and will you send it on to the developers of httrack?

comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Keywords: haspatch added

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: httrack.diff added

portfile patch

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: patch-src-webhttrack.diff added

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: patch-src-htsweb.c.diff added

comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

As for the second problem -- the path problem -- I'm not sure whether that's still an issue; I don't see that error message. But I did see that paths are hardcoded in a couple places, including in the usage message you quoted above, so I've updated the attached patches to fix that; this also ensures webhttrack won't inadvertently find and use a copy of httrack installed outside of MacPorts.

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Since Ross has not responded to the patches in this ticket, I've committed them in r91989.

Note: See TracTickets for help on using tickets.