cppcheck: fails to install in Leopard

[jpo@…]

Hi,

The building process of cppcheck 1.46.1 (and 1.45) fails in Leopard (10.5).

Error messages:

...
g++ -O2 -DNDEBUG -Wall -Ilib -Icli -c -o test/testautovariables.o test/testautovariables.cpp
In file included from test/testautovariables.cpp:22:
test/testsuite.h:49:65: error: macro "assert" passed 3 arguments, but takes just 1
test/testsuite.h:49: error: variable or field ‘assert’ declared void
...

[jpo@…]

The problem described above occurs during "make all". In particular, the compilation aborts during the compilation of the sub-target "testrunner".

With the following patch it is possible to build and install cppcheck in Mac OS X Leopard (10.5):

--- Portfile.1461       2010-12-26 19:00:54.000000000 +0000
+++ Portfile    2010-12-26 19:42:46.000000000 +0000
@@ -31,7 +31,7 @@
 
 build.args          CXX=${configure.cxx} \
                     DB2MAN=${prefix}/share/xsl/docbook-xsl/manpages/docbook.xsl
-build.target        all man
+build.target        cppcheck man
 
 test.run               yes
 test.target            test

[ryandesign@…]

Please report this problem to the developers of cppcheck.

[paj-macports@…]

Shall fix cppcheck so that the tests run.

[paj-macports@…]

I don't have a Leopard installation on which to test (shall build a VM this week). The following patch should work:

diff --git a/test/testsuite.h b/test/testsuite.h
index 69fb777..f83d721 100644
--- a/test/testsuite.h
+++ b/test/testsuite.h
@@ -23,6 +23,9 @@
 #include <sstream>
 #include "errorlogger.h"
 #include "redirect.h"
+#ifdef assert
+#   undef assert
+#endif
 
 class options;

[jpo@…]

Replying to ryandesign@…:

Please report this problem to the developers of cppcheck.

Yesterday I reported this problem upstream

• ​http://sourceforge.net/apps/trac/cppcheck/ticket/2360

There is already a comment in the ticket saying that it is safe to rename the assert method in the testsuite,h file.

/jpo

[paj-macports@…]

Fixed upstream.

[jpo@…]

Replying to paj-macports@…:

Fixed upstream.

You were faster than me ;)

For the record: Upstream fix: method assert method renamed to assert_. ​https://github.com/danmar/cppcheck/commit/58ddb3b0abd04b1dc1ac12c316b327d980189b1f

[ryandesign@…]

Resolved by updating the port to 1.47 (#28374).