New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #27998 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

lensfun @0.2.5 set install_name and current_version

Reported by: julians37@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc:
Port: lensfun

Description

The default build doesn't set install_name and doesn't use libtool so liblensfun.dylib isn't found at runtime unless DYLD_LIBRARY_PATH is set. Attached is a patch to rectify this by setting install_name.

I've also changed the build to set dylib_current_version. I'm not quite sure what to do about compatibility_version so I've left it at the default value (0.0.0) for now. Any advice?

Attachments

lensfun-025-set-install_name.patch (636 bytes) - added by julians37@… 2 years ago.
patch-build-tibs-target-mac-mak.diff (582 bytes) - added by julians37@… 2 years ago.

Change History

Changed 2 years ago by julians37@…

Changed 2 years ago by julians37@…

comment:1 Changed 2 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Not sure what you should set the library version numbers too; it's kinda upstream's responsibility to decide what their library version numbering scheme is going to be and to employ that in their Makefiles.

Note that the revision should increase to 1 (not 2).

comment:2 Changed 2 years ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.