New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #28089 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

gnofract4d 3.12 fails to build after libpng 1.4.5 update

Reported by: ak.ml@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: libpng Cc:
Port: gnofract4d

Description

:info:build /usr/bin/gcc-4.0 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -arch i386 -D_REENTRANT=1 -DTHREADS=1 -DPNG_ENABLED=1 -UNDEBUG -Ifract4d/c -I/opt/local/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 -c
 fract4d/c/imageIO.cpp -o build/temp.macosx-10.5-i386-2.6/fract4d/c/imageIO.o -Wall -I/opt/local/include/libpng14
:info:build cc1plus: warning: command line option "-Wstrict-prototypes" is valid for C/ObjC but not for C++
:info:build fract4d/c/imageIO.cpp: In constructor 'png_writer::png_writer(FILE*, IImage*)':
:info:build fract4d/c/imageIO.cpp:122: error: 'png_infopp_NULL' was not declared in this scope
:info:build fract4d/c/imageIO.cpp: In static member function 'static ImageWriter* ImageWriter::create(image_file_t, FILE*, IImage*)':
:info:build fract4d/c/imageIO.cpp:263: warning: enumeration value 'FILE_TYPE_JPG' not handled in switch
:info:build fract4d/c/imageIO.cpp: In constructor 'png_reader::png_reader(FILE*, IImage*)':
:info:build fract4d/c/imageIO.cpp:315: error: 'png_infopp_NULL' was not declared in this scope
:info:build fract4d/c/imageIO.cpp: In destructor 'virtual png_reader::~png_reader()':
:info:build fract4d/c/imageIO.cpp:328: error: 'png_infopp_NULL' was not declared in this scope
:info:build fract4d/c/imageIO.cpp: In member function 'virtual bool png_reader::read_header()':
:info:build fract4d/c/imageIO.cpp:354: error: 'int_p_NULL' was not declared in this scope
:info:build fract4d/c/imageIO.cpp: In member function 'virtual bool png_reader::read_tile()':
:info:build fract4d/c/imageIO.cpp:375: error: 'png_bytepp_NULL' was not declared in this scope
:info:build fract4d/c/imageIO.cpp: In static member function 'static ImageReader* ImageReader::create(image_file_t, FILE*, IImage*)':
:info:build fract4d/c/imageIO.cpp:395: warning: enumeration value 'FILE_TYPE_TGA' not handled in switch
:info:build fract4d/c/imageIO.cpp:395: warning: enumeration value 'FILE_TYPE_JPG' not handled in switch
:info:build error: command '/usr/bin/gcc-4.0' failed with exit status 1

According to the libpng ChangeLog http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt:

2. b. We removed the typecasted NULL definitions such as

         #define png_voidp_NULL    (png_voidp)NULL

      If you used these in your application, just use NULL instead.

I've updated fract4d/c/imageIO.cpp following 2b and it compiles fine.

I have a MacIntel with Leopard 10.5.8

Attachments

gnofract4d-3.12.log (102.3 KB) - added by ak.ml@… 4 years ago.
patch-imageIO.cpp.diff (1.3 KB) - added by ak.ml@… 4 years ago.

Change History

Changed 4 years ago by ak.ml@…

Changed 4 years ago by ak.ml@…

comment:1 Changed 4 years ago by ryandesign@…

  • Cc ryandesign@…, waqar@… removed
  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

comment:2 Changed 4 years ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Thanks, fixed in r75347

Note: See TracTickets for help on using tickets.