New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #28353 (closed update: fixed)

Opened 2 years ago

Last modified 2 years ago

eggdrop: update to 1.6.20

Reported by: dre@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch maintainer Cc:
Port: eggdrop

Description

Attaching two files; an updated Portfile and updated Makefile.in patch file.

Attachments

Portfile (1.1 KB) - added by dre@… 2 years ago.
Portfile
patch-Makefile.in.diff (428 bytes) - added by dre@… 2 years ago.
Makefile.in patch
portfile.diff (928 bytes) - added by dre@… 2 years ago.
Portfile diff
patch.diff (878 bytes) - added by dre@… 2 years ago.
patch diff

Change History

Changed 2 years ago by dre@…

Portfile

Changed 2 years ago by dre@…

Makefile.in patch

comment:1 Changed 2 years ago by ryandesign@…

  • Status changed from new to assigned
  • Owner changed from macports-tickets@… to ryandesign@…
  • Port set to eggdrop

This had been requested in #28295.

comment:2 follow-up: ↓ 3 Changed 2 years ago by ryandesign@…

Please submit a portfile diff, not a full portfile. Your full portfile that you submitted is based on an outdated portfile. Please consult the repository and obtain the latest current eggdrop portfile, then make your changes based on that, then submit a diff of it.

Changed 2 years ago by dre@…

Portfile diff

Changed 2 years ago by dre@…

patch diff

comment:3 in reply to: ↑ 2 Changed 2 years ago by dre@…

Replying to ryandesign@…:

Please submit a portfile diff, not a full portfile. Your full portfile that you submitted is based on an outdated portfile. Please consult the repository and obtain the latest current eggdrop portfile, then make your changes based on that, then submit a diff of it.

Added the two requested diffs.

comment:4 Changed 2 years ago by ryandesign@…

  • Keywords haspatch maintainer added
  • Status changed from assigned to closed
  • Resolution set to fixed
  • Summary changed from Bump eggdrop to 1.6.20 to eggdrop: update to 1.6.20

Thanks. That portfile diff allowed me to see what changes you wanted us to make, and I made them in r75864. However, your patch would not apply to the portfile in the repository; it was made against an earlier version of the portfile. Please always submit diffs made against the current version of the portfile in the repository.

Note also that we don't need diffs of your patchfiles, just of portfiles.

Note: See TracTickets for help on using tickets.