New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #29787 (closed submission: fixed)

Opened 2 years ago

Last modified 2 years ago

apache solr @ 3.2.0 - newport

Reported by: hayato_1980@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: java search Cc:
Port: apache-solr

Description

This is Portfile Apache Solr, search platform based on Apache Lucene, java.

Attachments

Portfile (1.7 KB) - added by hayato_1980@… 2 years ago.
solr (351 bytes) - added by hayato_1980@… 2 years ago.

Change History

Changed 2 years ago by hayato_1980@…

Changed 2 years ago by hayato_1980@…

comment:1 Changed 2 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Thanks.

comment:2 Changed 2 years ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Committed in r79407 with some changes:

distfiles ${name}-${version}.tgz

This line is unnecessary.

checksums sha1 78caf37494603d69096709ed31455e6e433bff63

We want to use more than one checksum type. For now, we suggest sha1 and rmd160.

set extracted ${workpath}/${name}-${version}

This value is already available in the variable ${worksrcpath}.

set target ${destroot}/${prefix}/share/java/${name}-${version}

There should be no "/" before ${prefix}. ${prefix} already begins with a "/".

fs-traverse -tails file ${extracted}/example {

switch -exact [ file type ${extracted}/example/${file}] {

directory {

xinstall -d -m 755 ${target}/${file}

}
file {

xinstall -m 644 ${extracted}/example/${file} ${target}/${file}

}

}

}

Why not simply copy the entire directory?

xinstall -m 755 ${filespath}/solr ${prefix}/bin

This needs to be installed into ${destroot}${prefix}/bin so that it is registered to the port and removed when the port is uninstalled.

This script assumes prefix is /opt/local but it might not be. Use a "@PREFIX@" placeholder in the script, then reinplace that in the portfile.

JAVA_HOME is also hardcoded into this script, and could be reinplaced from the portfile.

The variable CMDNAME in this script was never used. I assume is was supposed to have been used in the usage message.

post-deactivate {}

post-activate {}

These lines are unnecessary.

Note: See TracTickets for help on using tickets.