Ticket #30211 (closed defect: fixed)
gmp @5.0.2 did not detect Core i7
| Reported by: | M.Hami@… | Owned by: | mcalhoun@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | gmp corei i7 | Cc: | ryandesign@… |
| Port: | gmp |
Description (last modified by ryandesign@…) (diff)
When I install gmp on my iMac Core i7 it says:
Warning: No processor dependent assembly code being used. gmp might be slower.
I found an older patch ( patch-config.guess.i7.diff ) here which fix the problem. I could not find anything why it was removed. #28892
Please put it back in.
Change History
comment:1 Changed 2 years ago by ryandesign@…
- Cc mcalhoun@… removed
- Owner changed from macports-tickets@… to mcalhoun@…
- Description modified (diff)
comment:3 Changed 2 years ago by ryandesign@…
- Status changed from new to closed
- Cc ryandesign@… added
- Resolution set to fixed
I see upstream's main (unstable) development branch has this fix, but the 5.0 branch does not. So I guess we'll need this patch until the next version (5.1? 6.0?) comes out. Re-added patch in r80766. Revbump so i7 users rebuild to get the faster code.
comment:4 Changed 16 months ago by luke.renaud@…
It looks like the patch was correctly removed. The method that the patch used in now corrected, but this warning is still produced because the build_cpu name scheme has changed slightly since the Portfile was written. Currently the extra check that is performed should just check if $build_cpu is prefixed with corei, not that the two names are the same.
So the patch was added to gmp 5.0.1 in r77717, and removed when gmp was updated to 5.0.2 in r79373. The comment that had been added to the port in r77717 that the patch could be safely removed with gmp 5.0.2 appears to have been erroneous.