Opened 13 years ago
Closed 13 years ago
#30794 closed enhancement (fixed)
fizmo: use the right compiler and -arch flags
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | Christoph.Ender@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.1 |
| Keywords: | haspatch | Cc: | |
| Port: | fizmo |
Description
This patch updates the fizmo port so that it ensures it's UsingTheRightCompiler and architecture flags. May I commit it?
Attachments (1)
Change History (5)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | fizmo-archs.diff added |
|---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|
comment:2 follow-ups: 3 4 Changed 13 years ago by Christoph.Ender@…
Looks good, thanks for the update. OTOH, during testing I found some other problem (completely unrelated to this patch) which may sporadically result in a "malformed archive TOC entry" error during build. Adding the following line to the post-patch section will hotfix this issue:
reinplace "s|\$(AR) rcs|rm -f libfizmo.a ; \$(AR) rcs|g" ${worksrcpath}/src/fizmo/Makefile
If you like, you can add it to this patch right away.
comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to Christoph.Ender@…:
OTOH, during testing I found some other problem (completely unrelated to this patch) which may sporadically result in a "malformed archive TOC entry" error during build. Adding the following line to the post-patch section will hotfix this issue:
reinplace "s|\$(AR) rcs|rm -f libfizmo.a ; \$(AR) rcs|g" ${worksrcpath}/src/fizmo/Makefile
If you like, you can add it to this patch right away.
Committed in r82624, except that I made it a patchfile instead of a reinplace. This is less brittle, and allows someone to read the patchfile and see exactly what is being changed. But since this change had nothing to do with this ticket, it would have been better to file a separate ticket.
proposed patch