#31346 closed enhancement (fixed)
sqlite3: use libedit instead of readline
| Reported by: | jmroot (Joshua Root) | Owned by: | mww@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | sqlite3 |
Description
This will allow more dependents to be distributed in binary form, since libedit is BSD licensed whereas readline is GPLv3.
Attachments (3)
Change History (6)
Changed 13 years ago by jmroot (Joshua Root)
| Attachment: | sqlite3-libedit.patch added |
|---|
Changed 13 years ago by jmroot (Joshua Root)
| Attachment: | configure.patch added |
|---|
Changed 13 years ago by jmroot (Joshua Root)
| Attachment: | shell.c.patch added |
|---|
comment:1 Changed 13 years ago by mww@…
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 13 years ago by drkp (Dan Ports)
I think this is a good idea for sqlite as there are plenty of ports that depend on it (so, thanks!)
Do note that there are some limitations of libedit compared to readline --- in particular, I'm told its support for UTF-8 input isn't very good --- so we may want to think carefully about whether to do this for other ports too.
comment:3 Changed 13 years ago by jmroot (Joshua Root)
According to the changelog on the homepage, UTF-8 support was added in the release of 2010-04-24. So if the criticism you're seeing dates from before then, it's no longer valid.
It's true that libedit doesn't implement the full readline API, but if that's an issue for a client it shouldn't even build.
excellent idea -- thanks, commited in 84485