pianobar: fails to build with clang

[aguynamedryan+macports@…]

I just upgraded to Lion and decided to do a fresh install of MacPorts. pianobar failed to build with the following error:

:info:build In file included from src/settings.c:38:
:info:build In file included from src/settings.h:28:
:info:build src/libwaitress/waitress.h:30:10: fatal error: 'gnutls/gnutls.h' file not found
:info:build #include <gnutls/gnutls.h>
:info:build          ^

Looks like pianobar isn't seeing the /opt/local files. I've patched the Portfile so that it sets a -I and -L flag for the compiler. I also drop the now-unsused LIB*_INCLUDE variables

[aguynamedryan+macports@…]

Portfile patch

[aguynamedryan+macports@…]

log with error if anyone is curious

[ryandesign (Ryan Carsten Schmidt)]

Replying to aguynamedryan+macports@…:

Looks like pianobar isn't seeing the /opt/local files.

Probably because ​clang doesn't use CPATH or LIBRARY_PATH.

I've patched the Portfile so that it sets a -I and -L flag for the compiler. I also drop the now-unsused LIB*_INCLUDE variables

The revision should not be increased because this doesn't change the files that get installed, right?

I'm attaching a revised patch of how I would do this. What do you think?

I'm also removing the pre-destroot deletion of INSTALL, not necessary because the Makefile already declares install as a .PHONY target.

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[dyoung@…]

Cc Me!

[ibtaylor@…]

Adding the last two lines to build.args works for me.

build.args                  CC="${configure.cc} [get_canonical_archflags]" \
                            PREFIX=${prefix} \
                            CFLAGS=-std=c99 \
                            LIBAO_INCLUDE=${prefix}/include \
                            LIBFAAD_INCLUDE=${prefix}/include \
                            LIBMAD_INCLUDE=${prefix}/include \
                            LIBGNUTLS_CFLAGS="[exec pkg-config --cflags gnutls]" \
                            LIBGNUTLS_LDFLAGS="[exec pkg-config --libs gnutls]"

Really, it seems like ao, faad, mad, should be handled with pkg-config as well.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ibtaylor@…:

Adding the last two lines to build.args works for me.

Are you saying that the patch I attached above did not work?

[ryandesign (Ryan Carsten Schmidt)]

ibtaylor, please see my remark in the ticket.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

I'm also removing the pre-destroot deletion of INSTALL, not necessary because the Makefile already declares install as a .PHONY target.

r88248.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

Are you saying that the patch I attached above did not work?

It seems to work for me, so I'm committing it in r88249. But I don't have Lion / Xcode 4.2, so please let me know if this works for you now or not.