wireshark 1.6.x: several requests

[jpo@…]

This ticket was created in order to make several requests/comments regarding/about the current wireshark port:

1) Wireshark 1.6.x should be build by default with the following options:

• IPv6
  Pv6 networks are more common nowadays; and its numbers are expected to increase due to the recent exhaustion of the IPv4 address space; also, all recent MacOSX versions are IPv6 aware

• libgcrypt
  Needed by the ipsec support; also needed by capinfos to calculate the pcap files hashes (MD5, SHA1, ...)

• libsmi
  Enables wireshark to access SMI MIB module definitions (SNMP related)

2) The following variants are missing:

• geoip
• gtk3 (experimental)
  ​http://wiki.wireshark.org/GoingGTK3

3) The bzip2 requirement appears to be bogus.

4) Wireshark builds with lua and c-ares support even if the variants aren't specified (lua and c-ares need to be installed in the building system)

Note: some of these requests had already been applied to the wireshark-devel Portfile (see #29968)

Regards, jpo

[jpo@…]

wireshark Portfile patch

[jpo@…]

Patch changelog

• adds the MacPorts modeline at the beginning of the Portfile
• enforces the modeline (vim :retab)
• changes the order of the lua and the libsmi variants
• adds "default_variants +ipv6 +libgcrypt +libsmi" at the end of the file

/jpo

[raimue@…]

The +ipv6 variant was not enabled by default by request of the maintainer, see #17861.

[jpo@…]

Replying to raimue@…:

The +ipv6 variant was not enabled by default by request of the maintainer, see #17861.

Do you know why it wasn't enabled by default? There is no reason given in the ticket you mention.

Shouldn't this decision be revisited? Three years ago we were talking about Wireshark 1.0 [1] and Mac OS X 10.4/10.5 (and there were IPv4 addresses still available [2]).

/jpo

[1] - ​https://trac.macports.org/browser/trunk/dports/net/wireshark/Portfile?rev=46908 [2] - ​https://en.wikipedia.org/wiki/IPv4_address_exhaustion

[msavory@…]

I too would request making the IPv6 variant default now.

Also the latest build gives these warnings wireshark-1.6.5.tar.bz2

--->  Staging wireshark into destroot
Warning: violation by /opt/local/homeplug.py.sample
Warning: violation by /opt/local/register-dissector.py
Warning: violation by /opt/local/wspy_dissector.py
Warning: violation by /opt/local/wspy_libws.py
Warning: wireshark violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!

[ricci@…]

+python mtree violation (see #31757) and -lua picking up installed lua support fixed in r89676. Note that wireshark defaults to building with c-ares.

In the future, please separate different issues into different tickets, there are a number of disparate issues in this ticket that should be tracked separately, not together.

[jmr@…]

The whitespace changes in the patch make it very difficult to see what the actual functional changes are.

[ricci@…]

resolved in r94583