x48 port submission

[mklein-de (Michael Klein)]

This emulator is capable of providing a faithful replication of the HP48. It also has a debugger for the saturn processor.

[mf2k (Frank Schima)]

Sorry for the delay. I just started looking at this.

Some questions:

• Are you still interested in maintaining?
• Why not always download the ROMs? Does that change the license?

[mf2k (Frank Schima)]

Has duplicate #54224.

[mklein-de (Michael Klein)]

Replying to mf2k:

Sorry for the delay. I just started looking at this.

Some questions:

• Are you still interested in maintaining?

sure, can do that

• Why not always download the ROMs? Does that change the license?

that is quite possible, as the emulator itself is GPL.

[mf2k (Frank Schima)]

So my latest error with the +roms variant is in extract. Does this work for you?

$ sudo port build
--->  Computing dependencies for x48
--->  Fetching distfiles for x48
--->  Attempting to fetch x48-0.6.4.tar.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Attempting to fetch gxrom-r.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Attempting to fetch sxrom-j.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Verifying checksums for x48
--->  Extracting x48
Error: Failed to extract x48: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_github.com_macports_macports-ports_emulators_x48/x48/main.log for details.

I will attach the complete log.

[mf2k (Frank Schima)]

Here is my updated version of the Portfile

[mklein-de (Michael Klein)]

Replying to mf2k:

So my latest error with the +roms variant is in extract. Does this work for you?

it works with the original Portfile and fails with the updated Portfile

In the updated Portfile the following line is commented out:

extract.only    ${distname}${extract.suffix}

After adding this again it fails now in build:

--->  Building x48
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work/." && /usr/bin/make -j4 -w all
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work'
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work'
Making all in src
make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work/src'
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT actions.o -MD -MP -MF .deps/actions.Tpo -c -o actions.o actions.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT debugger.o -MD -MP -MF .deps/debugger.Tpo -c -o debugger.o debugger.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT device.o -MD -MP -MF .deps/device.Tpo -c -o device.o device.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT disasm.o -MD -MP -MF .deps/disasm.Tpo -c -o disasm.o disasm.c
debugger.c:1575:39: warning: format specifies type 'void *' but the argument has type 'word_20' (aka 'long') [-Wformat]
      printf("%d %p -> [%s] %s\n", i, ent, typ, dat);
                 ~~                   ^~~
                 %ld
mv -f .deps/device.Tpo .deps/device.Po
debugger.c:1582:39: warning: format specifies type 'void *' but the argument has type 'word_20' (aka 'long') [-Wformat]
      printf("%d %p -> [%s] %s\n", i, ent, typ, dat);
                 ~~                   ^~~
                 %ld
debugger.c:1588:3: error: non-void function 'get_stack' should return a value [-Wreturn-type]
  return;
  ^
2 warnings and 1 error generated.
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT emulate.o -MD -MP -MF .deps/emulate.Tpo -c -o emulate.o emulate.c
make[2]: *** [debugger.o] Error 1
make[2]: *** Waiting for unfinished jobs....

[mklein-de (Michael Klein)]

ok, I also have two small patches for clang here ;-)

[mklein-de (Michael Klein)]

updated updated Portfile

[mklein-de (Michael Klein)]

first patch

[mklein-de (Michael Klein)]

second patch

[mf2k (Frank Schima)]

In 95b2d9bde0b2dfd29cf5db7c1260776077cd8d36/macports-ports:

x48:

• New port

Closes: #32376

[aldurbano]

the functionality with keyboard is working. Tapping on the calculators keys with the trackpad not. To get a response the trackpad must *clicked*, pushed down. Would be possible adding the capability to react on tapping on the trackpad?

[mf2k (Frank Schima)]

Please do not re-open this ticket because the port has been added to Macports. Instead open a new ticket for this port with your enhancement request.