New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #33128 (closed update: fixed)

Opened 16 months ago

Last modified 16 months ago

ntfs-3g 2011.4.12 update

Reported by: and.damore@… Owned by: petri@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: pixilla@…
Port: ntfs-3g

Description

I'm attaching patch to update the port to 2012.1.15, latest version. Please confirm it works as expected.

Attachments

patch-port_ntfs_3g.diff (1.7 KB) - added by and.damore@… 16 months ago.
Portfile (2.4 KB) - added by petri@… 16 months ago.
New Portfile; updated maintainer e-mail
Portfile.new.diff (2.4 KB) - added by petri@… 16 months ago.

Change History

Changed 16 months ago by and.damore@…

comment:1 Changed 16 months ago by petri@…

I'm removing the line to delete mkfs.ntfs as ntfsprogs is rplaced by ntfs-3g. Also changing my email address in the port. Will retest.

comment:2 follow-ups: ↓ 4 ↓ 6 Changed 16 months ago by petri@…

Sorry, that line was supposed to be there. Anyway, attaching the new Portfile when having made sure it seems OK, as I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

Changed 16 months ago by petri@…

New Portfile; updated maintainer e-mail

comment:3 Changed 16 months ago by pixilla@…

  • Owner changed from petri@… to petri@…

comment:4 in reply to: ↑ 2 Changed 16 months ago by pixilla@…

Replying to petri@…:

I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

I have not used rsync in a while. Does it work to move the new "Portfile" to say "Portfile.new" and perform a "port sync"?

comment:5 Changed 16 months ago by pixilla@…

  • Cc pixilla@… added

Cc Me!

comment:6 in reply to: ↑ 2 ; follow-up: ↓ 7 Changed 16 months ago by and.damore@…

Replying to petri@…:

Sorry, that line was supposed to be there. Anyway, attaching the new Portfile when having made sure it seems OK, as I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

I wouldn't drop an error if mount.ntfs is present, I suggest to either put the code to rename mount.ntfs in that if block, so to correctly handle mount.ntfs presence, or to totally remove the check itself change the Portfile again if needed.

Also I see you've reverted dependency on port macfuse rather than fuse4x and removed license, probably you used a different Portfile version as base for editing. If you need the Portfile you have several options: you can download the Portfile I initially attached, perform a sync as Brad suggested or check the repository browser to see current portfile and its revisions.

comment:7 in reply to: ↑ 6 Changed 16 months ago by petri@…

Replying to and.damore@…:

I wouldn't drop an error if mount.ntfs is present, I suggest to either put the code to rename mount.ntfs in that if block, so to correctly handle mount.ntfs presence, or to totally remove the check itself change the Portfile again if needed.

I think mount.ntfs is something foreign, can I check for whether a previous port version has had the file on a particular ports install in some way (i.e., whether to touch the file, otherwise the option I'd go for would be to just mention it being there, perhaps as a vestigial item from an ancient ntfs-3g Portfile)?

Also I see you've reverted dependency on port macfuse rather than fuse4x and removed license, probably you used a different Portfile version as base for editing. If you need the Portfile you have several options: you can download the Portfile I initially attached, perform a sync as Brad suggested or check the repository browser to see current portfile and its revisions.

No, syncing (even after rm -rf:ing fuse/ntfs-3g) didn't help, but thanks for the repo browser link.

comment:8 follow-up: ↓ 9 Changed 16 months ago by petri@…

Gah, ignore my question in the first paragraph. Too much blood in my caffeine system.

comment:9 in reply to: ↑ 8 Changed 16 months ago by and.damore@…

Replying to petri@…:

Too much blood in my caffeine system.

I got a patch for that too.

Anyway if you don't know what mount.ntfs is and it's not in created at build time just skim the related lines from the Portfile. As soon as you give the clear-to-go we can commit it.

comment:10 Changed 16 months ago by and.damore@…

  • Type changed from defect to update

Can you give feedback about mount.ntfs question so we can commit?

comment:11 Changed 16 months ago by and.damore@…

  • Status changed from new to closed
  • Resolution set to fixed

Committed r89790, taking advantage of maintainer timeout.

comment:12 Changed 16 months ago by petri@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

Actually, the mount.ntfs-3g was installed by previous package versions and should it become installed in new versions, the file ought to me renamed to conform to mount_xyz naming in OS X. The ntfsprogs isn't mentioned in the description so I deleted the deletion of mkfs.ntfs, nor is the correct maintainer address correct, so I'm reopening and attaching the new diff. Sorry about the delay, have been busy with other things for a while.

Changed 16 months ago by petri@…

comment:13 Changed 16 months ago by and.damore@…

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.