New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #34480 (closed enhancement: fixed)

Opened 13 months ago

Last modified 13 months ago

port 2.1.0 - progress count leads to excessive lines in output

Reported by: macintosh@… Owned by: cal@…
Priority: Normal Milestone: MacPorts 2.1.1
Component: base Version: 2.1.0
Keywords: Cc: cal@…
Port:

Description (last modified by ryandesign@…) (diff)

I'm running an automatic nightly update by having an update script as part of periodic daily.

The problem is, that the progress counts introduced in port 2.1.0

--->  Updating database of binaries: 100.0%
--->  Scanning binaries for linking errors: 100.0%

leads to an excessive amount of totally superflous lines in the log file periodic.daily.

The problem has been described in details in the groups:

Attachments

mp-base-no-progress-if-stdout-no-tty.patch (4.6 KB) - added by cal@… 13 months ago.
Patch against base to prevent the use of \r when stdout is not a tty

Change History

comment:1 Changed 13 months ago by ryandesign@…

  • Description modified (diff)

comment:2 Changed 13 months ago by jberry@…

Note that there is an implementation of isatty available, and defined in pextlib. It's called from at least one place inside the port command, and should probably be used here to qualify use of the eye-candy.

Changed 13 months ago by cal@…

Patch against base to prevent the use of \r when stdout is not a tty

comment:3 follow-up: ↓ 5 Changed 13 months ago by cal@…

  • Owner changed from macports-tickets@… to cal@…
  • Status changed from new to assigned

Please test the attached patch and report whether this works for you.

comment:4 Changed 13 months ago by cal@…

  • Milestone set to MacPorts Future

comment:5 in reply to: ↑ 3 Changed 13 months ago by macintosh@…

Replying to cal@…:

Please test the attached patch and report whether this works for you.

WORKS :-)

comment:6 Changed 13 months ago by cal@…

  • Status changed from assigned to closed
  • Resolution set to fixed

r93221 in trunk, cherry-pick into release 2.1 in r93222.

comment:7 Changed 13 months ago by jmr@…

  • Milestone changed from MacPorts Future to MacPorts 2.1.1
Note: See TracTickets for help on using tickets.