New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #34969 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

pianobar: update to 2012.06.24

Reported by: aguynamedryan+macports@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: haspatch maintainer Cc:
Port: pianobar

Description

pianobar has released an update

Attachments

patch-Makefile.diff (1.9 KB) - added by aguynamedryan+macports@… 11 months ago.
patches for Makefile
pianobar-2012.06.24.diff (984 bytes) - added by aguynamedryan+macports@… 11 months ago.
patches for Portfile
main.log (45.9 KB) - added by ryandesign@… 11 months ago.
working_main.log (59.0 KB) - added by aguynamedryan+macports@… 11 months ago.
main.log when building pianobar works
pianobar-2012.06.24.2.diff (1.4 KB) - added by aguynamedryan+macports@… 11 months ago.
patches for Portfile

Change History

Changed 11 months ago by aguynamedryan+macports@…

patches for Makefile

Changed 11 months ago by aguynamedryan+macports@…

patches for Portfile

comment:1 Changed 11 months ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Thanks!

Changed 11 months ago by ryandesign@…

comment:2 Changed 11 months ago by ryandesign@…

Upgrading the port fails. I've attached the main.log.

Changed 11 months ago by aguynamedryan+macports@…

main.log when building pianobar works

Changed 11 months ago by aguynamedryan+macports@…

patches for Portfile

comment:3 Changed 11 months ago by aguynamedryan+macports@…

From what I can tease out from your log, line 264 has an error:

:info:build src/settings.h:87: error: expected specifier-qualifier-list before ‘PianoAudioQuality_t’

As with most GCC errors, this one is cryptic, but can mean "I don't know what PianoAudioQuality_t is".

Line 90 of your log seems to be including piano.h from /opt/local/include/piano.h instead of from src/libpiano/piano.h If that is the case, /opt/local/include/piano.h won't define PianoAudioQuality_t because PianoAudioQuality_t was added in this latest release.

I've attempted to update the Portfile to include "-I. -I./src/libpiano/" to try to pull the local copy of piano.h instead of your system's outdated piano.h file. Hopefully it works. Failing that, hopefully I've given you enough to tinker around with to cajole this thing into compiling.

comment:4 Changed 10 months ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed

r95379

Also, the patch you had attached here had lost some of the changes we had made before. I reinstated them before committing.

Note: See TracTickets for help on using tickets.