Ticket #35003 (closed update: fixed)
pv @1.2.0 request to update port to the latest version
| Reported by: | nonstop.server@… | Owned by: | ryandesign@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | haspatch | Cc: | meissnem@… |
| Port: | pv |
Description
Request to update port pv to the latest release (currently version 1.3.1).
A difference report of the Portfile is attached.
Note: The existing patch stat64.diff is successfully applied with fuzz 1 for file src/pv/loop.c, if this is regarded as an error or unwanted a new patch file should be created.
Attachments
Change History
Changed 11 months ago by nonstop.server@…
- Attachment Portfile-pv.diff added
comment:1 follow-up: ↓ 2 Changed 11 months ago by meissnem@…
nonstop.server@ -- are you interested in taking on the maintainer role? I rarely use pv anymore, so I'd rather it be in the hands of someone who cares...
comment:2 in reply to: ↑ 1 Changed 11 months ago by nonstop.server@…
Replying to meissnem@…:
Hi meissnem,
Thank you for your proposition however I'm not sure how much time I'll be able to spend on macports in the long run, so I would like to keep it the way it is.
I don't mind providing patches where and when I can without actually being the official maintainer.
comment:3 follow-up: ↓ 4 Changed 11 months ago by ryandesign@…
The attached diff contains both whitespace and functional changes. Please supply diffs that do only one or the other.
Changed 11 months ago by nonstop.server@…
- Attachment Portfile-pv_whitespace.diff added
proposed patch for whitespace changes
Changed 11 months ago by nonstop.server@…
- Attachment Portfile-pv_functional.diff added
proposed patch for functional changes
comment:4 in reply to: ↑ 3 Changed 11 months ago by nonstop.server@…
Replying to ryandesign@…:
The original diff has been split up in two diffs for whitespace and functional changes respectively.
Please see the newly attached difference reports.
comment:5 Changed 11 months ago by meissnem@…
These new patches look good to me. I do not have commit privileges, so ryandesign@ if you're still listening and would be willing to commit it that would be great.
comment:6 Changed 10 months ago by ryandesign@…
- Status changed from new to assigned
- Owner changed from macports-tickets@… to ryandesign@…
Thank you. But note that if we're going to make whitespace changes, then we want the port's fixed whitespace to conform to our style guidelines, which are 4 spaces per indent; that's what the modeline you're adding says too. I've committed the corrected whitespace and formatting changes in r95761.
comment:7 follow-up: ↓ 8 Changed 10 months ago by ryandesign@…
- Status changed from assigned to closed
- Resolution set to fixed
As for the functional changes, note that we want to use the rmd160 / sha256 checksum pair these days. There don't appear to be any downloads for this at Google Code (anymore?) so I removed that address from the master_sites. 1.3.4 is available in the mean time. I refreshed the stat64 patch. I committed the functional changes in r95762.
comment:8 in reply to: ↑ 7 Changed 10 months ago by nonstop.server@…
Replying to ryandesign@…:
Thank you for the upgrade and all the corrections.
I'll leave out the md5 checksum next time and keep white-spaces at four spaces in future patches.
proposed patch