proctools: bsdmake: setrlimit: Invalid argument

[chuckmcknight@…]

Was able to build manually by running the bsdmake at the command line and doing the build and install separately. The port command fails (see log below):

[ryandesign@…]

The log says:

bsdmake: setrlimit: Invalid argument

Since this was not a clean attempt, please "sudo port clean proctools", then try again, then attach the new main.log. It builds fine for me on Mountain Lion.

[chuckmcknight@…]

Ran sudo port clean proctools, the sudo port install proctors (see attached log main.2.log)

[chuckmcknight@…]

I hate auto-correct...

Should say:

Ran sudo port clean proctools, then ran sudo port install proctools (see attached log main.2.log).

[jmr@…]

I can't reproduce this on my 10.7 system, but it looks like the problem is actually in bsdmake.

[raimue@…]

There is only one call to setrlimit in bsdmake, which is at the beginning of ​main (line 751). According to the man page for setrlimit(2), valid values for the rlim_cur should be in the range from 0 to rlim_max. I could only think of a problem here if the second branch in the Apple related branch is taken which sets rlim_cur = OPEN_MAX. With a configuration such that OPEN_MAX > rlim_max this would be an invalid value.

Do you have any special configuration for the maximum number of open files on your system?

[chuckmcknight@…]

No special configs that I'm aware of. "ulimit -a" gives:

core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
file size               (blocks, -f) unlimited
max locked memory       (kbytes, -l) unlimited
max memory size         (kbytes, -m) unlimited
open files                      (-n) 8192
pipe size            (512 bytes, -p) 1
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 709
virtual memory          (kbytes, -v) unlimited

[raimue@…]

On my Mac OS X 10.8.2 build 12C54, ulimit -a returns the following list:

core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
file size               (blocks, -f) unlimited
max locked memory       (kbytes, -l) unlimited
max memory size         (kbytes, -m) unlimited
open files                      (-n) 256
pipe size            (512 bytes, -p) 1
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 709
virtual memory          (kbytes, -v) unlimited

So given that my system returns 256 and your system has 8192, there seems to be a different configuration. I will try to reproduce the issue and hopefully manage to patch bsdmake for this.

[ajdudman@…]

setrlimt patch

[ajdudman@…]

I also get a setrlimit: Invalid argument execution error. My hard and soft open files limits are 10240 and 12288, because my /etc/launchd.conf setting "limit maxfiles 10240 12288". I find setting rlim_max = rlim_cur = OPEN_MAX works.

[ajdudman@…]

The idea for the fix came from the discussion at ​http://old.tbamud.com/forum/thread/873.

[raimue@…]

Thank you very much for providing the patch! I never came around to do it myself.

Committed in r105220.