#36954 closed defect (wontfix)
Proposed fixes and improvements for dovecot2 port
| Reported by: | dave@… | Owned by: | jdberry |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | ryandesign (Ryan Carsten Schmidt) |
| Port: | dovecot2 |
Description
The libstemmer stuff depends on acceptance of #36952
Attachments (5)
Change History (17)
Changed 11 years ago by dave@…
| Attachment: | 0001-Add-missing-with-zlib.-Presumably-this-is-wanted-sin.patch added |
|---|
Changed 11 years ago by dave@…
| Attachment: | 0002-bzip2-support.patch added |
|---|
Changed 11 years ago by dave@…
| Attachment: | 0003-Presumably-we-should-never-say-opt-local-explicitly-.patch added |
|---|
Changed 11 years ago by dave@…
| Attachment: | 0004-Add-libstemmer-support.patch added |
|---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|---|
| Owner: | changed from macports-tickets@… to pixilla@… |
| Port: | dovecot2 added |
comment:2 Changed 11 years ago by dave@…
comment:4 Changed 11 years ago by skymoo (Adam Mercer)
| Cc: | dave@… removed |
|---|
No need to CC yourself when you're the reporter.
comment:7 Changed 10 years ago by pixilla (Bradley Giesbrecht)
dave: Sorry I missed this ticket and thank you for the patches.
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | dovecot2.diff added |
|---|
comment:8 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|
It looks like r120443 includes Dave's patches 0001, 0002 and 0004, but not 0003. I've attached a new patch which makes the following changes, obsoleting 0003:
- add explicit
--without-*configure args for features not enabled, to prevent opportunistic enabling - append to cppflags instead of overwriting it, since the default contains
-I${prefix}/include, thereby eliminating the need to manually add it back in in the lucene and libstemmer variants - remove commands appending
-L${prefix}/libto ldflags in lucene and libstemmer variants since that's already in the ldflags by default - remove command appending
-I/opt/local/libto cppflags in lucene variant because that directory doesn't contain any include files - remove version conditional around lucene variant which always evaluated to true
- libstemmer support requires lucene support; indicate this in the variant requirements
- fixed incorrect configure flag for enabling libstemmer support
- changed libstemmer dependency from lib to build because libstemmer only provides a static library, not a dynamic one
- a few minor whitespace edits for consistency
comment:9 Changed 5 years ago by mf2k (Frank Schima)
| Owner: | pixilla deleted |
|---|---|
| Status: | new → assigned |
See #57827
comment:10 Changed 4 years ago by mf2k (Frank Schima)
| Owner: | set to jdberry |
|---|
comment:11 Changed 3 years ago by mf2k (Frank Schima)
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
comment:12 Changed 3 years ago by jmroot (Joshua Root)
Although dovecot now installs what used to be dovecot2. Reopen if any of this is still relevant to the current dovecot port I guess.
Note: See
TracTickets for help on using
tickets.
The libstemmer patch has been accepted upstream, so it would be great to get these integrated if they're acceptable.