lua-lpeg @0.11: portfile parse error if lua is not installed

[cooljeanius (Eric Gallager)]

During my most recent selfupdate lua-lpeg gave me this message:

Failed to parse file devel/lua-lpeg/Portfile: Package lua was not found in the pkg-config search path.
Perhaps you should add the directory containing `lua.pc'
to the PKG_CONFIG_PATH environment variable
No package 'lua' found

[cooljeanius (Eric Gallager)]

installing lua makes this error go away, but I shouldn't have to install lua just to selfupdate

[larryv (Lawrence Velázquez)]

This line…

LDFLAGS="${configure.ldflags} [exec ${prefix}/bin/pkg-config lua --libs]"

…needs to go into a pre-build block or something, so that the exec command is not evaluated when the portfile is parsed.

[anddam (Andrea D'Amore)]

Replying to larryv@…:

This line…

LDFLAGS="${configure.ldflags} [exec ${prefix}/bin/pkg-config lua --libs]"

…needs to go into a pre-build block or something, so that the exec command is not evaluated when the portfile is parsed.

That's not possible AFAIK, even if you set a variable in an augmented phase it would not be available at portfile's main level. A correct approach is patching the makefile rather than passing the values on build args.

Committed r104585, ticket closed.

[anddam (Andrea D'Amore)]

Replying to egall@…:

but I shouldn't have to install lua just to selfupdate

Yes, sorry about that, you can uninstall it. Thanks for reporting.

[larryv (Lawrence Velázquez)]

Replying to and.damore@…:

That's not possible AFAIK, even if you set a variable in an augmented phase it would not be available at portfile's main level. A correct approach is patching the makefile rather than passing the values on build args.

Sorry, I wasn’t clear. You’d use a block like this:

pre-build {
    build.args-append   LDFLAGS="${configure.ldflags} [exec ${prefix}/bin/pkg-config lua --libs]"
}

Or set build.args all at once, if you’d like:

pre-build {
    build.args      CC="${configure.cc} [get_canonical_archflags]" \
                    LUADIR=${prefix}/include \
                    CFLAGS="${configure.cflags}" \
                    LDFLAGS="${configure.ldflags} [exec ${prefix}/bin/pkg-config lua --libs]"
}

These idioms obviate the need for unnecessary patching.

[anddam (Andrea D'Amore)]

Replying to larryv@…:

Sorry, I wasn’t clear. You’d use a block like this:

pre-build {
    build.args-append   LDFLAGS="${configure.ldflags} [exec ${prefix}/bin/pkg-config lua --libs]"
}

Ofc, -appending is a proper solution, I'm just too used to patching. Will change back to that soon.

[jmroot (Joshua Root)]

Patching is fine too. But lib dependencies aren't guaranteed to be available in the patch phase either, so you need to use backticks instead of exec to make the command execute in the makefile rather than the portfile.