Opened 11 years ago

Closed 11 years ago

#38856 closed update (fixed)

dansguardian 2.12.0.3

Reported by: mroman@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: dansguardian

Description

update dansguardian 2.12.0.3

Attachments (4)

Portfile-dansguardian.diff​ (2.5 KB) - added by mroman@… 11 years ago.
Portfile-dansguardian.2.diff​ (2.1 KB) - added by mroman@… 11 years ago.
Portfile-dansguardian.3.diff​ (3.2 KB) - added by mroman@… 11 years ago.
Portfile-dansguardian.4.diff​ (3.7 KB) - added by mroman@… 11 years ago.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by mroman@…

Attachment: Portfile-dansguardian.diff​ added

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Keywords: haspatch added
Version: 2.1.3

Why are you adding variants and not simply adding the new functionality always? They do not add any dependencies.

Changed 11 years ago by mroman@…

Attachment: Portfile-dansguardian.2.diff​ added

comment:2 Changed 11 years ago by mroman@…

I didn't know what to do with these flags (some additional code is compiled only and this functionality is activated after some edits in a config file). I have corrected it and changed commands for permissions correction of /var/log/dansguardian.

comment:3 Changed 11 years ago by mf2k (Frank Schima)

Please attach a unified diff.

Changed 11 years ago by mroman@…

Attachment: Portfile-dansguardian.3.diff​ added

comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

  • master_sites should be written to avoid redirects; see wiki:howto/AvoidRedirects.
  • Tcl commands should be used wherever possible instead of using exec to run shell commands. For example, exec mkdir -p can be replaced with xinstall -d. exec chown and exec chmod can be replaced with file attributes, which isn't recursive, but you can recurse yourself using fs-traverse.

Changed 11 years ago by mroman@…

Attachment: Portfile-dansguardian.4.diff​ added

comment:5 Changed 11 years ago by mroman@…

I hope it will meet all requirements this time ;)

comment:6 Changed 11 years ago by mroman@…

Is there anything wrong with this patch?

comment:7 Changed 11 years ago by fclaire@…

Hi mroman, thanks for the update: I'm looking forward to it.

Maybe try to ask on the macports devel mailing list for a committer to have a look.

comment:8 Changed 11 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: new → assigned

comment:9 Changed 11 years ago by larryv (Lawrence Velázquez)

Resolution: → fixed
Status: assigned → closed

Updated in r105952, with correct livecheck.

Note: See TracTickets for help on using tickets.