apr-util: add mysql variants

[dr@…]

port info apr-util
apr-util @1.5.2_1 (devel)
Variants:             (+)mysql5, no_bdb, no_sqlite, openldap, postgresql82, postgresql83, postgresql84, universal

Description:          apr-util is a library of useful utilities built with and intended to be used with the Apache Portable Runtime.
Homepage:             http://apr.apache.org/

Library Dependencies: apr, expat, libiconv, db46, sqlite3, mysql5
Platforms:            darwin
License:              Apache-2
Maintainers:          dluke@geeklair.net

There should be a selection for the new mysql5(1|5|6)-Versions..

[danielluke (Daniel J. Luke)]

I don't use mysql at all (and +mysql5 isn't a default variant). I'm happy to accept a patch to add/adjust the +mysql5 behavior, though.

[dr@…]

I attached a patch which adds variants for mysql51, mysql55 and mysql56. :)

[mp@…]

Not sure if variants are the way to go, see #39961

[larryv (Lawrence Velázquez)]

Replying to dr@…:

I attached a patch which adds variants for mysql51, mysql55 and mysql56. :)

Could you also add variants for mariadb and percona?

[danielluke (Daniel J. Luke)]

Does anyone/anything actually use the mysql5 support in apr-util (I'm just curious :) )?

[ryandesign (Ryan Carsten Schmidt)]

Replying to mp@…:

Not sure if variants are the way to go, see #39961

Variants are the way to go. However they should use port: dependencies not path:.

[mp@…]

Cc Me!

[dr@…]

Replying to dluke@…:

Does anyone/anything actually use the mysql5 support in apr-util (I'm just curious :) )?

Yes. I do ;)

[dr@…]

Replying to larryv@…:

Could you also add variants for mariadb and percona?

Unfortunately, I don't use neither mariadb nor percona..

[dr@…]

Cc Me!

[danielluke (Daniel J. Luke)]

All of the variants in the patch also point to ${prefix}/bin/mysql_config5, which doesn't seem right (since I believe all of the mysql5X ports can be installed at the same time).

Anyone who uses mysql want to provide an updated patch that is working that hopefully has: replaced path: dependencies with port: dependencies, points to whatever is correct for mysql_config5 for each variant, and also has maridb and percona support?

I can commit something if we fix the first two (and it can wait for someone who uses mariadb and/or percona to supply variants for those, if necessary).

Thanks!

[pixilla (Bradley Giesbrecht)]

I have a patch I will attach after my test builds finish.

[pixilla (Bradley Giesbrecht)]

Add mysql5{1,5,6}, mariadb and percona variants.

[cooljeanius (Eric Gallager)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Committed a slightly modified version of pixilla's patch in r112478 (maintainer timeout).

[danielluke (Daniel J. Luke)]

Thanks Ryan - I could have sworn that I checked this ticket a few times and there was no patch from pixilla yet (and trac doesn't send notifications for attachments, IIRC).