Sleuthkit upgrade to 4.1.3 fails

[dershow]

I just tried to upgrade sleuthkit from 4.1.2 to 4.1.3 and the upgrade fails. Here is the end of my build log:

:info:build /bin/sh ../../libtool --tag=CXX   --mode=link /usr/bin/clang++  -pipe -Os -arch x86_64  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -D_THREAD_SAFE -pthread -L/usr/local/lib -static -o img_cat img_cat.o ../../tsk/libtsk.la -lewf -ldl -lz -ldl -lstdc++ 
:info:build libtool: link: /usr/bin/clang++ -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -D_THREAD_SAFE -pthread -o img_stat img_stat.o  -L/opt/local/lib -L/usr/local/lib ../../tsk/.libs/libtsk.a -lewf -lz -ldl -lstdc++ -pthread
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build libtool: link: /usr/bin/clang++ -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -D_THREAD_SAFE -pthread -o img_cat img_cat.o  -L/opt/local/lib -L/usr/local/lib ../../tsk/.libs/libtsk.a -lewf -lz -ldl -lstdc++ -pthread
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build Undefined symbols for architecture x86_64:
:info:build   "_libewf_glob_free", referenced from:
:info:build       _ewf_image_close in libtsk.a(ewf.o)
:info:build Undefined symbols for architecture x86_64:
:info:build   "_libewf_glob_free", referenced from:
:info:build       _ewf_image_close in libtsk.a(ewf.o)
:info:build ld: symbol(s) not found for architecture x86_64
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build make[2]: *** [img_cat] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....
:info:build make[2]: *** [img_stat] Error 1
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_sleuthkit/sleuthkit/work/sleuthkit-4.1.3/tools/imgtools'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_sleuthkit/sleuthkit/work/sleuthkit-4.1.3/tools'
:info:build make: *** [all-recursive] Error 1
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_sleuthkit/sleuthkit/work/sleuthkit-4.1.3'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_sleuthkit/sleuthkit/work/sleuthkit-4.1.3" && /usr/bin/make -j8 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port sleuthkit returned: command execution failed
:debug:build Error code: CHILDSTATUS 80681 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
:info:build Warning: targets not executed for sleuthkit: org.macports.install org.macports.build org.macports.destroot
:notice:build Please see the log file for port sleuthkit for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_sleuthkit/sleuthkit/main.log

I do have the libewf port installed (@20100226) It seems that there is a link error when it tries to use this port.

[dershow]

I upgraded the libewf port and now sleuthkit does build. The attachment to the libewf upgrade here #42297 is the proposed new port, that I hope will be submitted.

[ryandesign (Ryan Carsten Schmidt)]

libewf is not in sleuthkit's dependency chain. It should either be added as a dependency of sleuthkit, or sleuthkit should not use libewf, even if it is installed.

[dershow]

Sleuthkit should be able to use libewf, because it adds an important feature. So, I would like to see it added as a dependent, which would be very easy since libewf now builds, or as a variant, which would mean more significant changes to the sleuthkit port. It seems that Sleuthkit does have a configuration option to disable afflib. It also has an option to disable afflib. It appears that afflib could have a similar issue, as there is an old port for that as well. Apparently, afflib3 is now deprecated, and afflib4 should be used. I will separately create a ticket for that update.

[jessekornblum@…]

I've added libewf to the dependencies for Sleuthkit. I've tested this change with the patch to libewf in ticket #42297 and verify it compiles.

[mf2k (Frank Schima)]

r116591. I also:

1. Increased the revision since this is a new library dependency so everyone gets the update and has the same build.
2. Replaced tabs with spaces to be consistent with the rest of the Portfile.