Opened 10 years ago

Closed 10 years ago

#43537 closed submission (fixed)

psfex: please add as new port

Reported by: cdeil (Christoph Deil) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: tim@…
Port: psfex

Description

Tim, could you please add PSFEx (http://www.astromatic.net/software/psfex) to Macports?

If you don't have time I might give it a shot, because a fried and I both need it.

Attachments (2)

Portfile (2.0 KB) - added by cdeil (Christoph Deil) 10 years ago.
Portfile.2 (2.0 KB) - added by cdeil (Christoph Deil) 10 years ago.
Use modern checksum format

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by cdeil (Christoph Deil)

Attachment: Portfile added

comment:1 Changed 10 years ago by cdeil (Christoph Deil)

Portfile attached.

Works for me on Mac OS X 10.9

I made it by copy & pasting & adapting the Portfiles from sextractor and scamp.

comment:2 Changed 10 years ago by mf2k (Frank Schima)

Type: requestsubmission
Version: 2.2.1

Quick note:

comment:3 Changed 10 years ago by cdeil (Christoph Deil)

Should I attach a Portfile using the modern checksum format or will the person that reviews and commits the file simply do that on the fly?

comment:4 Changed 10 years ago by mf2k (Frank Schima)

You increase your chances of the file being committed if you attach a new version of Portfile (or patch if it is one). This saves us committers time.

Changed 10 years ago by cdeil (Christoph Deil)

Attachment: Portfile.2 added

Use modern checksum format

comment:5 Changed 10 years ago by cdeil (Christoph Deil)

I've attached an updated Portfile.2 using the modern checksum format.

Is this ready for commit or should I change something else?

comment:6 Changed 10 years ago by mf2k (Frank Schima)

Why does line 31 say?

eval configure.cflags-append

Is "eval" necessary? I've never seen that usage before.

comment:7 Changed 10 years ago by cdeil (Christoph Deil)

It's there because I copied the Portfile from SExtractor. Here you can see that 5 Ports use this ... 4 of which are very related Astromatic software: https://github.com/sakuro/macports/search?q=%22eval+configure.cflags-append%22&type=Code

What is the correct way to write this? Simply remove the "eval"?

comment:8 Changed 10 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

It appears it is correct then! r119783.

Note: See TracTickets for help on using tickets.