Opened 10 years ago

Closed 6 years ago

#44460 closed defect (worksforme)

atlas @3.10.2+gcc48 fails to build on PPC

Reported by: josephsacco Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.1
Keywords: Cc: Veence (Vincent), cooljeanius (Eric Gallager), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: atlas

Description

atlas @3.10.2+gcc48 fails to build on PPC. This is a regression bug. The PPC-specific patches from the previous release [3.10.1_5] have gone missing.

Only two of the three patches from version 3.10.1_5:

(1) patch-ATL_cmm4x4x128_av_c.diff <== no longer required
(2) patch-emit_mm_c.diff
(3) patch-makes-Make.lib.diff

still apply. The changes in patch(1) have already been integrated into the source code.

Patch(2) resolves the problem with the dst vector instruction:

dst vector instruction is optional for the PowerPC (not allowed without -force_cpusubtype_ALL option)

With Patch(2) applied, the build for atlas @3.10.2+gcc48 completes, but fails to create the shared version(s) of lib atlas. Patch(3) may help. I am testing this now.

-Joseph

Attachments (3)

Portfile.diff (2.5 KB) - added by josephsacco 10 years ago.
Portfile.diff
patch-emit_mm_c.diff (620 bytes) - added by josephsacco 10 years ago.
patch-makes-Make.lib.diff (2.5 KB) - added by josephsacco 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:2 Changed 10 years ago by Veence (Vincent)

Oops. Sorry for that. I'll restore them asap.

comment:3 Changed 10 years ago by josephsacco

No big deal. The only people who do not make mistakes are dead... :-)

There is a bunch of post-build stuff in the current Portfile that has been commented out. Will those lines need to be re-activated to get the shared versions of the atlas libraries built?

-Joseph

comment:4 Changed 10 years ago by josephsacco

To answer my own question... The post-build stuff in the current Portfile that has been commented out needs to be re-activated to get the shared versions of the atlas libraries built. The files in the static atlas libraries are compiled with -fPIC. The code in the post-build section uses the files in the static libraries to construct shared versions of the atlas libraries.

-Joseph

comment:5 Changed 10 years ago by Veence (Vincent)

Thanks a lot for digging into this. I’ll do everything necessary tomorrow. I don’t want to impose on your kindness, but if you had a moment to post the deleted patches, it’d spare me the complex shebang of dredging them up out of the SVN black hole. Thanks so much again!

Last edited 10 years ago by Veence (Vincent) (previous) (diff)

Changed 10 years ago by josephsacco

Attachment: Portfile.diff added

Portfile.diff

Changed 10 years ago by josephsacco

Attachment: patch-emit_mm_c.diff added

Changed 10 years ago by josephsacco

Attachment: patch-makes-Make.lib.diff added

comment:6 Changed 10 years ago by josephsacco

You are welcome. See attached diffs.

-Joseph

comment:7 Changed 10 years ago by Veence (Vincent)

Thanks a lot. Committed in r122764. Hope it'll work, and apologies once again for this botch-up.

comment:8 in reply to:  7 Changed 10 years ago by cooljeanius (Eric Gallager)

Replying to vince@…:

Thanks a lot. Committed in r122764. Hope it'll work, and apologies once again for this botch-up.

I think some of the comments were screwed up in r122764... Pretty sure the $Id$ line is supposed to stay a comment, for example.

comment:9 Changed 10 years ago by Veence (Vincent)

Geez. Thanks. Fixed in r122765. I commented the first line and run a 'port lint' that reported no error. I hope it's a clincher this time… :|

comment:10 Changed 10 years ago by josephsacco

Right!! See the Portfile example shown in section 4.3.1 of the MacPorts Guide.

-Joseph

Last edited 10 years ago by josephsacco (previous) (diff)

comment:11 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: MarcusCalhoun-Lopez added

comment:12 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: worksforme
Status: newclosed

Since atlas no longer has a gcc48 variant, I think this ticket can be safely closed.

Note: See TracTickets for help on using tickets.