Opened 10 years ago

Closed 10 years ago

#45375 closed defect (fixed)

openconnect: +ssl variant builds against gnutls anyway

Reported by: Schamschula (Marius Schamschula) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.1
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg), Mathias.Laurin+macports.org@…
Port: openconnect

Description

openconnect +ssl variant builds against gnutls anyway.

Fixed configure.args. Be explicit as to what to enable and what to disable.

Attachments (1)

Portfile-openconnect.diff (1.2 KB) - added by Schamschula (Marius Schamschula) 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-openconnect.diff added

comment:1 Changed 10 years ago by neverpanic (Clemens Lang)

If I installed openconnect -gnutls with this patch, I'd still get a GnuTLS OpenConnect. That's bad.

You should pass both --without-openssl and --without-gnutls by default, then remove one of them and replace it with the corresponding --with option in a variant.

Of course, if OpenConnect doesn't build without either GnuTLS or OpenSSL, you should have the Portfile error out if both variants are disabled.

comment:2 Changed 10 years ago by jmroot (Joshua Root)

Cc: khindenburg@… Mathias.Laurin+macports.org@… added
Summary: openconnectopenconnect: +ssl variant builds against gnutls anyway

comment:3 Changed 10 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.