#46466 closed defect (fixed)
Fix lirc build on Yosemite
| Reported by: | DanielO (Daniel O'Connor) | Owned by: | ecronin (Eric Cronin) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | haspatch | Cc: | ctreleaven (Craig Treleaven) |
| Port: | lirc |
Description
clang is fussier about inline routes, de-inline them to work around it.
Attachments (1)
Change History (7)
Changed 9 years ago by DanielO (Daniel O'Connor)
| Attachment: | lirc-yosemite-fix.diff added |
|---|
comment:1 follow-up: 6 Changed 9 years ago by ctreleaven (Craig Treleaven)
comment:2 Changed 9 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added |
|---|---|
| Owner: | changed from macports-tickets@… to ecronin@… |
| Port: | lirc added |
Thanks! In the future, please fill in the Port field and Cc the port maintainers (port info --maintainers lirc), if any.
comment:3 follow-up: 5 Changed 9 years ago by ecronin (Eric Cronin)
The right fix is probably to make those functions 'static inline' since they're defined in .c files (and it isn't clang being fussy, it's -std=c99 vs -std=c89). However the Portfile also already blacklists *clang* as a workaround, so I'm not sure why you're hitting this. Did you remove that blacklist?
This is a dup of #41498 (except the blacklisting was supposed to force gcc), I'll fix the inlines and un-blacklist clang and then set maintainership to Craig like we discussed in that ticket but never acted on.
comment:4 Changed 9 years ago by ecronin (Eric Cronin)
| Cc: | ctreleaven@… added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Successfully builds on Mavericks with XCode clang, don't have a way to test that it runs any more, but this seems to be entirely a compile-time issue.
comment:5 Changed 9 years ago by DanielO (Daniel O'Connor)
Replying to ecronin@…:
The right fix is probably to make those functions 'static inline' since they're defined in .c files (and it isn't clang being fussy, it's -std=c99 vs -std=c89). However the Portfile also already blacklists *clang* as a workaround, so I'm not sure why you're hitting this. Did you remove that blacklist?
It did say.. Warning: All compilers are either blacklisted or unavailable; defaulting to first fallback option
when building (I should have mentioned, sorry..)
comment:6 Changed 9 years ago by DanielO (Daniel O'Connor)
Replying to ctreleaven@…:
Thanks for the patches. Could I ask how you've tested this? Do you have a receiver (or transmitter) attached to your Mac? I only use the UDP interface.
I am trying to use an FTDI dongle - I think it should work but I haven't got it building yet. I actually want to control my air conditioner so I'm not sure lirc will work :)
Also, I note that the LIRC project has been more active recently. LIRC 0.9.2 was released about a month ago. I've been meaning to try building/running it; the build system has changed substantially, however.
Fun times ahead!
Thanks for the patches. Could I ask how you've tested this? Do you have a receiver (or transmitter) attached to your Mac? I only use the UDP interface.
Also, I note that the LIRC project has been more active recently. LIRC 0.9.2 was released about a month ago. I've been meaning to try building/running it; the build system has changed substantially, however.