xinit: typo in startx: Xorg wont start

[joergahrens (Jörg Ahrens)]

line 67 is

export X11_PREFS_DOMAIN=org.macports ".X11"

but should be

export X11_PREFS_DOMAIN=org.macports".X11"

look at the space before ".X11

[joergahrens (Jörg Ahrens)]

Replying to joerg@…:

line 67 is

export X11_PREFS_DOMAIN=org.macports ".X11"

but should be

export X11_PREFS_DOMAIN=org.macports".X11"

look at the space before ".X11

hm ... updated to xinit 1.3.4_0 on another machine and this typo isn't there ? It's OK in /opt/local/var/macports/software/xinit/xinit-1.3.4_0.darwin_13.x86_64.tbz2 but wrong in /opt/local/var/macports/software/xinit/xinit-1.3.4_0.darwin_10.x86_64.tbz2

[ryandesign (Ryan Carsten Schmidt)]

xinit appears to be using cpp to create this file. This appears to be ill-advised since this is not C code. This causes various warnings with the version of cpp in Yosemite's Xcode. like:

/usr/bin/cpp  -DXINITDIR=/opt/local/etc/X11/xinit -DXRDB=xrdb -DXMODMAP=xmodmap -DTWM=twm -DXCLOCK=xclock -DXTERM=xterm -DXSERVER=/opt/local/bin/X -DXAUTH=xauth -DXINIT=xinit -DLIBDIR=/opt/local/lib -DSHELL_CMD=/bin/sh -DHAS_COOKIE_MAKER -DMK_COOKIE="/opt/local/bin/openssl rand -hex 16" -D__libexecdir__="/opt/local/libexec" -D__bindir__="/opt/local/bin" -DBUNDLE_ID_PREFIX="org.macports" startx.cpp | /opt/local/bin/gsed -e '/^#  *[0-9][0-9]*  *.*$/d' -e '/^#line  *[0-9][0-9]*  *.*$/d' -e '/^[ 	]*XCOMM$/s/XCOMM/#/' -e '/^[ 	]*XCOMM[^a-zA-Z0-9_]/s/XCOMM/#/' -e '/^[ 	]*XHASH/s/XHASH/#/' -e '/\@\@$/s/\@\@$/\\/' > startx
startx.cpp:24:19: warning: missing terminating ' character [-Winvalid-pp-token]
XCOMM server there's a pretty good chance you want to bias the Xorg clients
                  ^
startx.cpp:25:26: warning: missing terminating ' character [-Winvalid-pp-token]
XCOMM over the old system's clients.
                         ^
startx.cpp:95:4: error: invalid preprocessing directive
        # Don't push this into the background becasue it can cause
          ^
startx.cpp:95:7: warning: missing terminating ' character [-Winvalid-pp-token]
        # Don't push this into the background becasue it can cause
             ^
startx.cpp:132:11: warning: empty character constant [-Winvalid-pp-token]
    XCOMM '' required to prevent cpp from treating "/*" as a C comment.
          ^
startx.cpp:133:6: warning: empty character constant [-Winvalid-pp-token]
    /''*|\./''*)
     ^
startx.cpp:133:13: warning: empty character constant [-Winvalid-pp-token]
    /''*|\./''*)
            ^
startx.cpp:305:13: warning: missing terminating '"' character [-Winvalid-pp-token]
eval XINIT \"$client\" $clientargs -- \"$server\" $display $serverargs
            ^
7 warnings and 1 error generated.

and with the version of cpp on Snow Leopard's Xcode, I guess it processes things differently in such a way that would not make a difference for C code but does for this code.

[jeremyhu (Jeremy Huddleston Sequoia)]

Indeed...

[jeremyhu (Jeremy Huddleston Sequoia)]

Probably the easiest thing for now is to use port:tradcpp =/

[jeremyhu (Jeremy Huddleston Sequoia)]

r132770