#47500 closed defect (fixed)
git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number
| Reported by: | dliessi (Davide Liessi) | Owned by: | Ionic (Mihai Moldovan) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | gorticus (Jason Mitchell) |
| Port: | git-flow-devel |
Description
Version comparison (e.g. port outdated) is confused by commit ids used as version numbers: the next commit id could be less than the current, in lexicographic order.
Using the date of the commit in AAAAMMDD format like e.g. in ffmpeg-devel, frescobaldi-devel, gccxml-devel, ensures that version comparison works as expected.
(An update in git-flow-devel is unlikey, given that it hasn't changed since 2012, but I think that it is important to fix this, because you never know.)
Attachments (1)
Change History (7)
Changed 9 years ago by dliessi (Davide Liessi)
| Attachment: | Portfile-git-flow.diff added |
|---|
comment:1 Changed 9 years ago by dliessi (Davide Liessi)
comment:2 Changed 9 years ago by Ionic (Mihai Moldovan)
| Owner: | changed from macports-tickets@… to ionic@… |
|---|---|
| Status: | new → assigned |
Maintainer timeout.
comment:3 Changed 9 years ago by Ionic (Mihai Moldovan)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed as r135346. Thanks!
comment:4 Changed 9 years ago by gorticus (Jason Mitchell)
Sorry for not responding in time, and posting to a closed ticket, but I'm not sure defining the version is working as expected, consider:
$ port livecheck git-flow-devel git-flow-devel seems to have been updated (port version: 15aab26490facf285acef56cb5d61025eacb3a69, new version: 1ffb6b1091f05466d3cd27f2da9c532a38586ed5)
however
15aab26 - 2012/09/25 (develop)1ffb6b1 - 2011/02/14 (master)
On a different note, I've been considering removing the nvie-based gitflow ports, precisely because people seem neither to realize it is effectively abandoned, see https://github.com/nvie/gitflow, nor recognize that the actively developed AVH Edition (https://github.com/petervanderdoes/gitflow) exists.
In the case of the hash driven git-flow-devel, while it may be preferred to set version in the Portfile, if kept, as in ffmpeg-devel, it's probably best to simply set livecheck.type none
My preference is to remove the nvie ports, and make the AVH Edition the default.
comment:5 follow-up: 6 Changed 9 years ago by dliessi (Davide Liessi)
I'm sorry I didn't consider livecheck: I should have redefined livecheck (which in this case is defined in the github PortGroup) to do the right thing.
Yes, the easiest solution is to set livecheck.type none.
comment:6 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to davide.liessi@…:
Yes, the easiest solution is to set
livecheck.type none.
Done in r142456.
No need to increase the epoch, since the current version string (commit id) begins with
1and the new version string (AAAAMMDD date) obviously begins with2; also there haven't been any version updates to this subport since its creation.