Ticket #4823 (closed defect: fixed)
tags can't have underscores or dashes
| Reported by: | yeled@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | base | Version: | 1.0 |
| Keywords: | Cc: | pguyot@… | |
| Port: |
Description
This is the code in portfetch.tcl:
proc getdisttag {name} {
if {[regexp {.+:([0-9A-Za-z_-]+)} $name match tag]} {
return $tag
} else {
return ""
}
}
yet if you add a a tag (like vim had for +aqua) with an underscore or a dash, it fails and falls back to the master_sites
---> Fetching vim Error: No defined site for tag: app_aqua, using master_sites
Change History
comment:2 Changed 8 years ago by yeled@…
--- src/port1.0/portfetch.tcl.orig 2005-09-04 01:32:56.000000000 +1000 +++ src/port1.0/portfetch.tcl 2005-09-04 01:32:47.000000000 +1000 @@ -234,7 +234,7 @@
}
foreach site $site_list {
- if {[regexp {([a-zA-Z]+:.+/?):([a-zA-Z]+)} $site match site tag]} {
+ if {[regexp {([a-zA-Z]+:.+/?):([0-9a-zA-Z_-]+)} $site match site tag]} {
lappend portfetch::$tag $site
} else {
lappend portfetch::$list $site
---8<--- that's it folks.


adding pguyot@… as it's Paul's regexp line that I'm trying to make work here.