#51785 closed update (fixed)
Qalculate update
| Reported by: | jjstickel (Jonathan Stickel) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | libqalculate qalculate-gtk |
Description
A new version of Qalculate has been released. Patches for the portfiles libqalculate and qalculate-gtk are attached.
Attachments (3)
Change History (8)
comment:1 follow-up: 2 Changed 8 years ago by mf2k (Frank Schima)
Changed 8 years ago by jjstickel (Jonathan Stickel)
| Attachment: | libqalculate_Portfile.diff added |
|---|
Changed 8 years ago by jjstickel (Jonathan Stickel)
| Attachment: | libqalculate_unordered.patch added |
|---|
Changed 8 years ago by jjstickel (Jonathan Stickel)
| Attachment: | qalculate-gtk_Portfile.diff added |
|---|
comment:2 Changed 8 years ago by jjstickel (Jonathan Stickel)
Replying to mf2k@…:
Comments:
- Since you are (wisely) switching to the github portgroup, all
depends_*statements should be changed todepends_*-appendto not overwrite the portgroup dependencies.- It looks like you are referencing the
patchfile libqalculate_unordered.patchbut that is not attached to this ticket.
Thanks for the review. Depends statements fixed in the new attachments. The patchfile for libqalculate is also now attached.
comment:3 follow-up: 4 Changed 8 years ago by mf2k (Frank Schima)
| Keywords: | haspatch maintainer added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Version: | 2.3.4 |
Would you mind if I fix up the spacing a little on these ports? Also I want to remove the reference to "for GNU/Linux" in the description for qalculate-gtk.
comment:4 Changed 8 years ago by jjstickel (Jonathan Stickel)
Replying to mf2k@…:
Would you mind if I fix up the spacing a little on these ports? Also I want to remove the reference to "for GNU/Linux" in the description for qalculate-gtk.
Go ahead. I thought about adjusting the description and some spacing issues, but I didn't want to add clutter to the portfile diffs.
I use emacs (emacs-app), and it doesn't do the spacing automatically, even with the correct header line. Is there a trick to this?
Comments:
depends_*statements should be changed todepends_*-appendto not overwrite the portgroup dependencies.patchfile libqalculate_unordered.patchbut that is not attached to this ticket.