mythtv-core.27 building internal ffmpeg

[jmcintyre]

The internal build of ffmpeg if not compatible with the version fo x264 in ports and produces the following build error:

:info:build /usr/bin/clang -I. -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_multimedia_mythtv.27/mythtv-core.27/work/mythtv-3c7582e9/mythtv/external/FFmpeg/ -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -D_ISOC99_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_DARWIN_C_SOURCE -DPIC -DHAVE_AV_CONFIG_H -pipe -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -std=c99 -fomit-frame-pointer -fPIC -g -Wall -Wno-parentheses -Wno-format-zero-length -Wdisabled-optimization -Wpointer-arith -Wno-pointer-sign -Wwrite-strings -Wtype-limits -Wundef -Wno-pointer-to-int-cast -Wstrict-prototypes -O3 -fno-math-errno -fno-signed-zeros -O3 -fno-math-errno -fno-signed-zeros -Qunused-arguments -Werror=implicit-function-declaration -Werror=return-type -w  -MMD -c -o libavcodec/loco.o libavcodec/loco.c
:info:build libavcodec/libx264.c:162:9: error: use of undeclared identifier 'x264_bit_depth'
:info:build     if (x264_bit_depth > 8)
:info:build         ^
:info:build libavcodec/libx264.c:612:9: error: use of undeclared identifier 'x264_bit_depth'
:info:build     if (x264_bit_depth == 8)
:info:build         ^
:info:build libavcodec/libx264.c:614:14: error: use of undeclared identifier 'x264_bit_depth'
:info:build     else if (x264_bit_depth == 9)
:info:build              ^
:info:build libavcodec/libx264.c:616:14: error: use of undeclared identifier 'x264_bit_depth'
:info:build     else if (x264_bit_depth == 10)
:info:build              ^
:info:build 4 errors generated.

Newer versions of ffmpeg have been updated to handle this the change in x264: ​https://trac.ffmpeg.org/ticket/6932

[ctreleaven (Craig Treleaven)]

See fix developed by reporter:

​https://github.com/jmcintyre/macports-ports/commit/1b0ec4aa88ed0957822d59c5d24d4b3b5a1017a6

[jmcintyre]

Craig, are you interested in a pull request for this? The original one I made was closed some time ago. I'd also be happy to do this for 0.28 if you are interested in having that compiling again too.