Opened 2 years ago
Closed 20 months ago
#65405 closed enhancement (fixed)
Frotz @2.5.3: Add option for sound and sdl interface
| Reported by: | mbrethen | Owned by: | jmroot (Joshua Root) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.7.2 |
| Keywords: | haspatch | Cc: | |
| Port: | frotz |
Description (last modified by mbrethen)
Attached Portfile.diff adds variants "snd" and "sdl" and also archives docs in ${prefix}/share/doc/${name}. Note: the Makefile.diff has also been updated to remove a hardcoded ${prefix}.
Attachments (3)
Change History (7)
Changed 2 years ago by mbrethen
| Attachment: | patch-Makefile added |
|---|
comment:1 follow-up: 2 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)
Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.
comment:2 Changed 2 years ago by mbrethen
Replying to ryandesign:
Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.
Re-uploaded diff--lmk if that's acceptable.
Changed 2 years ago by mbrethen
comment:3 Changed 2 years ago by mbrethen
| Description: | modified (diff) |
|---|
comment:4 Changed 20 months ago by jmroot (Joshua Root)
| Owner: | set to jmroot |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
patch Makefile to use ${prefix} instead of hardcoded path