postgresql14 broken on 10.6: error: conflicting types for ‘CollationCreate’ (both with gcc-4.2 and gcc12)

[barracuda156]

:info:build pg_collation.c:55: error: conflicting types for ‘CollationCreate’
:info:build ../../../src/include/catalog/pg_collation.h:82: error: previous declaration of ‘CollationCreate’ was here
:info:build pg_collation.c: In function ‘CollationCreate’:
:info:build pg_collation.c:196: warning: passing argument 3 of ‘heap_form_tuple’ from incompatible pointer type
:info:build gnumake[3]: *** [pg_collation.o] Error 1
:info:build gnumake[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_databases_postgresql14/postgresql14/work/postgresql-14.7/src/backend/catalog'
:info:build gnumake[2]: *** [catalog-recursive] Error 2

Same failure on PPC natively and Rosetta. Log is from 10.6.8 Rosetta.

[barracuda156]

It also fails with gcc12:

:info:build /opt/local/bin/gcc-mp-12 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -pipe -Os -arch ppc -I../../../src/include  -I/opt/local/include -I/opt/local/include/libxml2  -I/opt/local/include  -c -o pg_collation.o pg_collation.c
:info:build pg_collation.c:46:1: error: conflicting types for 'CollationCreate'; have 'Oid(const char *, Oid,  Oid,  char,  _Bool,  int32,  const char *, const char *, const char *, _Bool,  _Bool)' {aka 'unsigned int(const char *, unsigned int,  unsigned int,  char,  _Bool,  int,  const char *, const char *, const char *, _Bool,  _Bool)'}
:info:build    46 | CollationCreate(const char *collname, Oid collnamespace,
:info:build       | ^~~~~~~~~~~~~~~
:info:build In file included from pg_collation.c:25:
:info:build ../../../src/include/catalog/pg_collation.h:74:17: note: previous declaration of 'CollationCreate' with type 'Oid(const char *, Oid,  Oid,  char,  bool,  int32,  const char *, const char *, const char *, bool,  bool)' {aka 'unsigned int(const char *, unsigned int,  unsigned int,  char,  unsigned char,  int,  const char *, const char *, const char *, unsigned char,  unsigned char)'}
:info:build    74 | extern Oid      CollationCreate(const char *collname, Oid collnamespace,
:info:build       |                 ^~~~~~~~~~~~~~~
:info:build pg_collation.c: In function 'CollationCreate':
:info:build pg_collation.c:196:48: warning: passing argument 3 of 'heap_form_tuple' from incompatible pointer type [-Wincompatible-pointer-types]
:info:build   196 |         tup = heap_form_tuple(tupDesc, values, nulls);
:info:build       |                                                ^~~~~
:info:build       |                                                |
:info:build       |                                                _Bool *
:info:build In file included from pg_collation.c:18:
:info:build ../../../src/include/access/htup_details.h:793:87: note: expected 'bool *' {aka 'unsigned char *'} but argument is of type '_Bool *'
:info:build   793 |                                                                  Datum *values, bool *isnull);
:info:build       |                                                                                 ~~~~~~^~~~~~
:info:build gnumake[3]: *** [pg_collation.o] Error 1
:info:build gnumake[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_databases_postgresql14/postgresql14/work/postgresql-14.7/src/backend/catalog'
:info:build gnumake[2]: *** [catalog-recursive] Error 2

[barracuda156]

Looks like a known error: ​https://reviews.freebsd.org/file/data/x5ug27okoayalihkhzsn/PHID-FILE-djgp5hb3uikho37my7tp/databases_postgresql10-server_files_patch-icu68

[dgilman (David Gilman)]

In bfbd57e500d63729bd89d599cfc23b3232abf387/macports-ports (master):

postgresql16: new port

Closes: #40501
Closes: #37929
Closes: #36511
Closes: #36128
Closes: #33145
Closes: #66529
Closes: #67638
Closes: #29752
Closes: #66689
Closes: #67203
Closes: #67713
Closes: #68119
Closes: #67339