Opened 12 months ago

Closed 11 months ago

#67580 closed defect (fixed)

libmagic @5.44_0: pkgconfig file is missing CFlags: directive

Reported by: rafork (raf) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: libmagic

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Using pkg-config --cflags libmagic produces an empty line when it should output -I/opt/local/inlude. pkg-config --libs libmagic correctly outputs -L/opt/local/lib -lmagic. This lead to my libmagic client not compiling. The .pc file is missing a line that should say: 

  Cflags: -I${includedir}

Diff is attached.

Attachments (1)

libmagic.pc.patch​ (338 bytes) - added by rafork (raf) 12 months ago.
patch for pkgconfig file

Download all attachments as: .zip

Change History (4)

Changed 12 months ago by rafork (raf)

Attachment: libmagic.pc.patch​ added

patch for pkgconfig file

comment:1 Changed 12 months ago by rafork (raf)

Keywords: haspatch added

comment:2 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Owner: set to ryandesign
Status: new → accepted
Summary: libmagic @5.44_0: pkfconfig file is missing CFlags: directive → libmagic @5.44_0: pkgconfig file is missing CFlags: directive

Thanks. Looks like the developers have made a similar change already for the next version:

​https://github.com/file/file/commit/8bc37a45bad67bc4604471c64f0c9f3372b55d2c

The port's revision will have to be increased.

comment:3 Changed 11 months ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: accepted → closed

In 17c401e488210c6842760dc97e21b5a74be44881/macports-ports (master):

file: Add deps; add static lib; fix pkg-config file

Add bzip2, xz, and zstd deps to help identify more file types?

Also install static library.

Use upstream patch to add missing Cflags to pkg-config file.

Remove getline patch which doesn't seem to be needed anymore.

Closes: #67580

Note: See TracTickets for help on using tickets.