xxhashlib 0.8.2: Build failure on 10.7 Lion with Xcode clang

[thestr4ng3r (Florian Märkl)]

The build currently fails due to a crash of the Xcode-supplied clang:

0  clang 0x0000000100c57bb2 main + 12932498
Stack dump:
0.	Program arguments: /usr/bin/clang -cc1 -triple x86_64-apple-macosx10.7.0 -emit-obj -disable-free -disable-llvm-verifier -main-file-name xxhash.c -pic-level 2 -mdisable-fp-elim -masm-verbose -munwind-tables -target-cpu core2 -target-linker-version 136 -coverage-file /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_xxhash/xxhashlib/work/xxhash-0.8.2/xxhash.o -resource-dir /usr/bin/../lib/clang/4.2 -I /opt/local/include -fmodule-cache-path /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_xxhash/xxhashlib/work/.tmp/clang-module-cache -I/opt/local/include -Os -Wall -Wextra -Wconversion -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wstrict-overflow=2 -fconst-strings -fdebug-compilation-dir /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_xxhash/xxhashlib/work/xxhash-0.8.2 -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -mstackrealign -fblocks -fobjc-runtime=macosx-10.7.0 -fobjc-dispatch-method=mixed -fobjc-default-synthesize-properties -fdiagnostics-show-option -o xxhash.o -x c xxhash.c 
1.	./xxhash.h:3429:4: current parser token 'if'
2.	./xxhash.h:3371:1: parsing function body 'XXH64_hashFromCanonical'
3.	./xxhash.h:3371:1: in compound statement ('{}')

I experienced this locally and it can also be seen in ​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/155535 (stdout also attached for preservation)

A workaround is to use a different compiler:

sudo port install xxhashlib configure.compiler=macports-clang-11

Maybe this should be done in the Portfile only for Lion?

[chrstphrchvz (Christopher Chavez)]

Possible workaround: ​https://github.com/macports/macports-ports/pull/19897

[mascguy (Christopher Nielsen)]

Replying to chrstphrchvz:

Possible workaround: ​https://github.com/macports/macports-ports/pull/19897

Superseded by the following PR. And I've confirmed that this fixes the crash on 10.7:

​https://github.com/macports/macports-ports/pull/19899

[thestr4ng3r (Florian Märkl)]

In 6bb42f25bf183114ebda0f11909e226f22fdf641/macports-ports (master):

xxhash*: Fix 10.7 Lion clang segfault

Closes: #67963