wireshark{3,4} doesn't respect +python variant when building

[hexane360 (Colin Gilgenbach)]

Wireshark has +python variants, but currently those just ensure *a* python is installed, not that the specified python is actually used.

The following diff seems to fix this, but it hasn't been tested rigorously:

--- macports-ports/net/wireshark4/Portfile	2023-10-04 14:47:14
+++ ports/net/wireshark4/Portfile	2023-10-05 11:51:44
@@ -172,6 +172,8 @@
     set py_conflicts [lreplace ${pythons_ports} ${i} ${i}]
     variant ${py_port} description "Use python ${py_ver} during build" conflicts {*}${py_conflicts} "
         depends_build-append      port:${py_port}
+        configure.args-append     -DPython3_ROOT_DIR=\"${frameworks_dir}/Python.framework/Versions/${py_ver}/bin\"
+        configure.args-append     -DPython3_FIND_STRATEGY=LOCATION
     "
 }

[ryandesign (Ryan Carsten Schmidt)]

Replying to hexane360:

+        configure.args-append     -DPython3_ROOT_DIR=\"${frameworks_dir}/Python.framework/Versions/${py_ver}/bin\"

Why would these quotes need to be preceded with backslashes?

Edit: Oh, because the whole variant code is enclosed in quotes.

[i0ntempest]

Fixed in ​https://github.com/macports/macports-ports/commit/0170190b710d068b80a6999bab49a71c593cee05