Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#68689 closed defect (fixed)

CMake no longer finds OpenBLAS

Reported by: szhorvat (Szabolcs Horvát) Owned by: catap (Kirill A. Korinsky)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: catap (Kirill A. Korinsky), barracuda156, NicosPavlov, michaelld (Michael Dickens), mascguy (Christopher Nielsen)
Port: openblas, cmake

Description (last modified by szhorvat (Szabolcs Horvát))

CMake is no longer finding OpenBLAS and I am not sure why.

I am using:

OpenBLAS @0.3.24 (math, science)
cmake @3.24.4 (devel)

Fully updated ports tree, no local modifications.

Test CMake project:

cmake_minimum_required(VERSION 3.24)
project(Foo)
find_package(BLAS REQUIRED)
message(STATUS BLAS found: ${BLAS_LIBRARIES})

Configure it with cmake -DBLA_VENDOR=OpenBLAS -DCMAKE_PREFIX_PATH=/opt/local. Then it shows the error Could NOT find BLAS (missing: BLAS_LIBRARIES)

This used to work not so long ago. I am not sure when it broke. It also affects building ports that link to OpenBLAS.

My system:

macOS 13.6 22G120 arm64 Xcode 15.0.1 15A507

Change History (8)

comment:1 Changed 6 months ago by szhorvat (Szabolcs Horvát)

Description: modified (diff)

comment:2 Changed 6 months ago by barracuda156

This is haunting us.

comment:3 Changed 6 months ago by szhorvat (Szabolcs Horvát)

There's already a PR from Kirill with a fix for this.

comment:4 Changed 6 months ago by catap (Kirill A. Korinsky)

Owner: set to catap
Resolution: fixed
Status: newclosed

In 659ab537c015f73d5a95bcd642c6e06899ccc9eb/macports-ports (master):

openblas: update to 0.3.25

Closes: #68689

Co-authored-by: Szabolcs Horvát <szhorvat@…>

comment:5 Changed 6 months ago by catap (Kirill A. Korinsky)

Sad, my hack at doesn't help at least on buildbots :(

comment:6 Changed 6 months ago by jmroot (Joshua Root)

I'm not sure how it would make any difference: @ at the start of the line just means the command is not echoed to output when it is run, and - just means make will continue even if the command's exit status is nonzero.

comment:7 Changed 6 months ago by catap (Kirill A. Korinsky)

Yes, it doesn't; here the correct fix: https://github.com/macports/macports-ports/pull/21419

The root cause of missleading patch that I've start to dig on that and achived the expected behaviour without completley tested port destroot. When it was merged, I discovered that it doesn't work and start to dig why my ugly and unexpected patch help on local machine and doesn't help on build bot.

At that investigation I've discovered the real fix for the issue which I've opened as the second PR.

Last edited 6 months ago by catap (Kirill A. Korinsky) (previous) (diff)

comment:8 Changed 6 months ago by catap (Kirill A. Korinsky)

In ff29da7e45bfa9173d4c4279663a26652bf25068/macports-ports (master):

OpenBLAS: keep cmake integration

Closes: #68689

Note: See TracTickets for help on using tickets.