mpv @0.37.0 is broken on most of the systems

[barracuda156]

It is broken now pretty badly, far beyond just powerpc: ​https://ports.macports.org/port/mpv/details Likely just wrong settings are chosen.

If it is broken beyond repair, old systems should be pegged to the last version which builds and works.

[kencu (Ken)]

mpv uses the latest SDK features, for the most part

all older systems should use MPlayer instead, just as good.

[i0ntempest]

Seems that on every failing system except for macOS 11 it’s because of SDK version being too old. If you want to maintain support for older systems maybe it’s time to make a legacy port, as I’m unable to test and maintain stuff on old systems. But we do still have mplayer.

Also… when’s the last time we heard from Ionic?

[barracuda156]

So portfile forces +x11 variant for old systems, which requires libplacebo, which is broken on old systems: ​https://trac.macports.org/ticket/68962 This makes no sense :)

[barracuda156]

Replying to kencu:

mpv uses the latest SDK features, for the most part

all older systems should use MPlayer instead, just as good.

I cannot make it work for video output, unfortunately. This is not to claim it does not work, just a statement of fact: on my system it builds, but crashes on video playback. Audio works.

I will try building it on 10.4, if I have most of needed dependencies.

16. S. AFAIR, 0.34.1 version of mpv actually worked.

[i0ntempest]

libplacebo is needed no matter what. +x11 is really an old remnant, if we do decide to split a legacy port out of current portfile it will be removed (from this portfile) along with other stuff that used to work on old systems.

[barracuda156]

Replying to i0ntempest:

libplacebo is needed no matter what. +x11 is really an old remnant, if we do decide to split a legacy port out of current portfile it will be removed (from this portfile) along with other stuff that used to work on old systems.

I did not dig into the code yet, but I suspect that it will be a pointless endeavor to try fixing what was broken in recent versions, and rather makes sense to peg the last functional version as it were.

If no one is gonna bother fixing it in coming days, I can verify that what works and restore a fallback. Rather have some version working than leave it broken indefinitely.

[barracuda156]

Replying to i0ntempest:

libplacebo is needed no matter what.

It was just added by you in 0.37.0, it seems: ​https://github.com/macports/macports-ports/commit/155d173926353818286c372661b3071055e88afa

[barracuda156]

So there are two problems with 0.36.0:

1. A commit which has broken patches: ​https://github.com/macports/macports-ports/commit/b6cb56f5d86f11127102ed6b0c1f66d8d78bbf0b

2. Issue #67903

[barracuda156]

UPD. Well, upstream deliberately broken 0.37.0 with ​https://github.com/mpv-player/mpv/commit/23de1deaaaace05bb9504567a852ac66e76a1ad1 No surprise it is in fact broken.

[barracuda156]

In b31e620e1ff4fdcc22acdfb5a30ee21e092e9276/macports-ports (master):

mpv: restrict to Catalina and above

Commit ​https://github.com/mpv-player/mpv/commit/23de1deaaaace05bb9504567a852ac66e76a1ad1 has broken pre-Catalina systems. Restrict mpv port to platforms where it builds.
Closes: #68963