mysql5 readline support

[n0ts (Naoya Nakazawa)]

Mysql5 is not support readline.

I found below the patch. This patch is added variant readline.

--- /opt/local/var/macports/sources/rsync.macports.org/release/ports/databases/mysql5/Portfile.orig     2008-05-05 13:56:36.000000000 +0900
+++ /opt/local/var/macports/sources/rsync.macports.org/release/ports/databases/mysql5/Portfile  2008-05-26 15:53:07.000000000 +0900
@@ -68,6 +68,12 @@
     startupitem.stop    "${prefix}/share/${mysql}/mysql/mysql.server stop"
 }
 
+variant readline {
+    # enable readline
+    depends_lib-append  port:readline
+    configure.args-append  --with-readline
+}
+
 pre-destroot {
     # Some directories we must have in all cases
     xinstall -m 755 -d ${destroot}${sysconfdir}

[ryandesign (Ryan Carsten Schmidt)]

readline functionality is probably useful enough to enable always, not in a variant. I'll look into this.

[ryandesign (Ryan Carsten Schmidt)]

After a little investigation ("./configure --help"), it looks to me as though "--with-readline" is the default, for mysql3, mysql4 and mysql5, and means "use the readline library included with MySQL". Alternately, you can use "--without-readline" which means "don't use the included readline but use the system readline" which in our case would mean "use the MacPorts readline". We could do that, but would that provide any advantage? I'm also curious how you arrived at the conclusion that "Mysql5 is not support readline" and whether the +readline variant you supplied actually does anything.

[ryandesign (Ryan Carsten Schmidt)]

Dave Feldman sent me this reply via email:

In fact, I did experience problems with mysql5 installed from macports. While emacs keybindings appeared to work fine, vi keybindings did not work at all despite being enabled in my .inputrc. When I modified my Portfile to add --with-readline and reinstalled mysql5, vi keybindings worked perfectly fine.