Changes between Initial Version and Version 2 of Ticket #17191

Timestamp:

Mar 21, 2009, 10:51:05 PM (15 years ago)

Author:

ryandesign (Ryan Carsten Schmidt)

Comment:

There are several problems with the port as submitted.

• The master_sites should just be "sourceforge" (efficiency issue; this way you get all the sourceforge mirrors instead of just the one you specified).
• The distfiles line should be replaced with "distname ${name}${version}-src" (stylistic issue).
• configure.args should not include --prefix=${prefix} (redundancy issue; MacPorts already puts --prefix=${prefix} in configure.pre_args for you).
• The remaining configure args should use ${prefix} instead of /opt/local (accuracy issue; MacPorts may be in a different prefix).
• I assume the entire pre-build block can be deleted; it's not appropriate for a port to call the port command to build another port. That's what dependencies are for, which this port already declares sufficiently.
• The mixture of tabs and spaces should be replaced with all spaces (stylistic issue).
• There should be an $Id$ line at the top (stylistic issue).

I'll try fixing these issues and submitting a new port.