MPlayer: binary_codecs variant

[ryandesign (Ryan Carsten Schmidt)]

The binary_codecs variant of MPlayer did nothing at all, because it checked whether darwin_i386 or darwin_powerpc variants were set in order to decide what to do, but because no "platform darwin i386" or "platform darwin powerpc" section existed anywhere in the portfile, the variant did nothing. Those platform sections used to exist, but got removed somewhere along the way without consideration for the impact this would have on the binary_codecs variant.

I re-added empty platform statements in r50951 and now the variant fails with:

Error: Target org.macports.configure returned: configure failure: shell command " cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_multimedia_MPlayer/work/MPlayer-1.0rc2" && ./configure --prefix=/mp --with-extraincdir=/mp/include/lzo:/mp/include --with-extralibdir=/mp/lib:/mp/lib/samba3 --datadir=/mp/share/MPlayer --confdir=/mp/etc/MPlayer --mandir=/mp/share/man --enable-gif --enable-png --enable-jpeg --enable-liblzo --enable-libvorbis --enable-mad --disable-faad-external --enable-largefiles --disable-smb --disable-live --disable-dvdnav --disable-dvdread --disable-cdparanoia --disable-freetype --disable-fontconfig --disable-unrarlib --disable-fribidi --disable-enca --disable-libcdio --disable-xvid --disable-x264 --disable-speex --disable-theora --disable-faac --disable-ladspa --disable-libdv --disable-toolame --disable-twolame --disable-xmms --disable-musepack --disable-sdl --disable-aa --disable-caca --disable-x11 --disable-gl --disable-arts --disable-esd --disable-lirc --with-codecsdir=/mp/share/MPlayer/codecs --enable-macosx --enable-macosx-finder-support --enable-macosx-bundle --enable-qtx " returned error 1
Command output: Unknown parameter: --with-codecsdir=/mp/share/MPlayer/codecs

That's on Mac OS X 10.5.6 Intel with Xcode 3.1.2 and MacPorts 1.7.1.

I found this as a result of a post to the mailing list, and in ​my response I discussed the issue further.